From 95d6fed8b561db5573339f806127488066f75e5a Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Fri, 9 Jun 2023 12:19:02 +0530 Subject: [PATCH 1/2] fix: expire `RECORDER_INTERCEPT_FLAG` in one hour Leaving this running in prod can be dangerous. --- frappe/recorder.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/recorder.py b/frappe/recorder.py index 8229b862af37..1f31181d5349 100644 --- a/frappe/recorder.py +++ b/frappe/recorder.py @@ -169,7 +169,7 @@ def status(*args, **kwargs): @do_not_record @administrator_only def start(*args, **kwargs): - frappe.cache.set_value(RECORDER_INTERCEPT_FLAG, 1) + frappe.cache.set_value(RECORDER_INTERCEPT_FLAG, 1, expires_in_sec=60 * 60) @frappe.whitelist() From 2a578ac50aef601ea3a98df4cca3df8068a09559 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Fri, 9 Jun 2023 12:30:18 +0530 Subject: [PATCH 2/2] perf: Use cached doc in workflows --- frappe/model/workflow.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/model/workflow.py b/frappe/model/workflow.py index 1a5207733107..0e345a651538 100644 --- a/frappe/model/workflow.py +++ b/frappe/model/workflow.py @@ -210,7 +210,7 @@ def validate_workflow(doc): def get_workflow(doctype) -> "Workflow": - return frappe.get_doc("Workflow", get_workflow_name(doctype)) + return frappe.get_cached_doc("Workflow", get_workflow_name(doctype)) def has_approval_access(user, doc, transition):