From 0dd2e8927ad190f3c33966131342b5fd84013c62 Mon Sep 17 00:00:00 2001 From: Nikhil <30789322+nk521@users.noreply.github.com> Date: Wed, 30 Nov 2022 14:34:09 +0530 Subject: [PATCH] fix: check for bad zip files during unzipping in file doctype (#19058) * check for bad zip files (cherry picked from commit 53957447b3739aacdacc7cee983340d5632141f9) --- frappe/core/doctype/file/file.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/frappe/core/doctype/file/file.py b/frappe/core/doctype/file/file.py index 0c215015892c..34b8a606dd0b 100755 --- a/frappe/core/doctype/file/file.py +++ b/frappe/core/doctype/file/file.py @@ -423,7 +423,10 @@ def unzip(self) -> list["File"]: continue file_doc = frappe.new_doc("File") - file_doc.content = z.read(file.filename) + try: + file_doc.content = z.read(file.filename) + except zipfile.BadZipFile: + frappe.throw(_("{0} is a not a valid zip file").format(self.file_name)) file_doc.file_name = filename file_doc.folder = self.folder file_doc.is_private = self.is_private