8000 fix(role): Set desk properties (e.g. search_bar) to 1 for roles with desk_access (backport #21162) by mergify[bot] · Pull Request #21231 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(role): Set desk properties (e.g. search_bar) to 1 for roles with desk_access (backport #21162) #21231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2023

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Jun 4, 2023

This is an automatic backport of pull request #21162 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…desk access (#21162)

Replace get_doc with new_doc, because default values are not retrieved when using get_doc. Some roles with desk_access had no access to most features of the desk, such as the search bar or the form's sidebar.

(cherry picked from commit 66eb377)
@mergify mergify bot requested review from a team and phot0n and removed request for a team June 4, 2023 05:47
@ankush ankush merged commit 23ce3a0 into version-14-hotfix Jun 4, 2023
@ankush ankush deleted the mergify/bp/version-14-hotfix/pr-21162 branch June 4, 2023 05:51
frappe-pr-bot pushed a commit that referenced this pull request Jun 6, 2023
# [14.38.0](v14.37.1...v14.38.0) (2023-06-06)

### Bug Fixes

* changed for section with features and testimonial web temlates ([9bc5c37](9bc5c37))
* changed section with card url field to small text ([1815103](1815103))
* Check if signature already exist ([6463dab](6463dab))
* currency formatter got incorrect format when use precision 0  ([#21239](#21239)) ([#21240](#21240)) ([6e5248a](6e5248a))
* declare the function ([#21261](#21261)) ([#21262](#21262)) ([9a68696](9a68696))
* do not render custom cards if workspace does not contain content ([795c894](795c894))
* doctype name localization ([#21197](#21197)) ([#21200](#21200)) ([62f25f7](62f25f7))
* fit and recenter map when section is expanded ([5d2a3ab](5d2a3ab))
* form tour set parent tab active. ([#21163](#21163)) ([#21184](#21184)) ([ae09cf9](ae09cf9))
* handle multiple webform for same doctype ([5243143](5243143))
* handle read only property ([a0e2c28](a0e2c28))
* Load map libraries at build time to avoid async issues during geolocation render ([d287dc9](d287dc9))
* Load map libraries at build time to avoid async issues during geolocation render ([e128c9d](e128c9d))
* **role:** Set desk properties (e.g. search_bar) to 1 for roles with desk access ([#21162](#21162)) ([#21231](#21231)) ([23ce3a0](23ce3a0))
* **safe_eval:** Normalize code passed before validating the code ([e58b721](e58b721))
* ui tour popover when outside viewport ([#21164](#21164)) ([#21205](#21205)) ([c3dc409](c3dc409))
* **UX:** Notify if newly created user has no roles ([#21251](#21251)) ([#21254](#21254)) ([e203bc1](e203bc1))
* **ux:** re routes based on setup_complete ([#21118](#21118)) ([#21185](#21185)) ([5e425e2](5e425e2))

### Features

* formatter for `Attach` and `Attach Image` fields ([92659ca](92659ca))
* log all DDL queries ([#21107](#21107)) ([a693c6d](a693c6d))
* read-only geolocation (GDE-86) ([bf24d87](bf24d87))
* used cached version of document in mapper ([#21186](#21186)) ([#21189](#21189)) ([7f46640](7f46640))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.38.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
0