fix: Avoid update_order twice on Kanban load
#19011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The older logic called `kanban.update()` on a refresh (not on load) and returned from `render()` - Due to a recent PR, it calls `kanban.update()` AND builds a new board on load, which invokes `update_order` twice consecutively and causes a timestamp error to be thrown
phot0n
reviewed
Nov 25, 2022
Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #19011 +/- ##
===========================================
- Coverage 63.57% 63.44% -0.14%
===========================================
Files 750 750
Lines 67637 67637
Branches 6027 6027
===========================================
- Hits 43003 42909 -94
- Misses 21234 21269 +35
- Partials 3400 3459 +59
Flags with carried forward coverage won't be shown. Click here to find out more. |
phot0n
approved these changes
Nov 25, 2022
mergify bot
pushed a commit
that referenced
this pull request
Nov 25, 2022
* fix: Avoid `update_order` twice on kanban load - The older logic called `kanban.update()` on a refresh (not on load) and returned from `render()` - Due to a recent PR, it calls `kanban.update()` AND builds a new board on load, which invokes `update_order` twice consecutively and causes a timestamp error to be thrown * chore: Remove redundant condition Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com> (cherry picked from commit a4db455)
phot0n
pushed a commit
that referenced
this pull request
Nov 25, 2022
* fix: Avoid `update_order` twice on kanban load - The older logic called `kanban.update()` on a refresh (not on load) and returned from `render()` - Due to a recent PR, it calls `kanban.update()` AND builds a new board on load, which invokes `update_order` twice consecutively and causes a timestamp error to be thrown * chore: Remove redundant condition Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com> (cherry picked from commit a4db455) Co-authored-by: Marica <maricadsouza221197@gmail.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 29, 2022
# [14.17.0](v14.16.0...v14.17.0) (2022-11-29) ### Bug Fixes * Avoid `update_order` twice on Kanban load ([#19011](#19011)) ([#19013](#19013)) ([c6e2d16](c6e2d16)) * broken link for email tracking pixels ([#19030](#19030)) ([#19032](#19032)) ([ca520e0](ca520e0)) * Correctness in get_role_permissions and has_perm JS APIs (backport [#18877](#18877)) ([#18976](#18976)) ([cc2cd5f](cc2cd5f)) * default value options: sort ([#19019](#19019)) ([#19022](#19022)) ([3ec6d9c](3ec6d9c)) * discovery and styling issues in grid buttons ([a6bda7f](a6bda7f)) * handle "No Letterhead" in new print format builder ([#18990](#18990)) ([#18992](#18992)) ([1ad1cab](1ad1cab)) * horizontal scroll in rtl language ([906336e](906336e)) * only accept string values for `key` ([237a152](237a152)) * webform read only field not working ([#19026](#19026)) ([ce505ca](ce505ca)) * z-index for barcode and awesomeplete (backport [#18893](#18893)) ([#19003](#19003)) ([0191858](0191858)) ### Features * add param letterhead to frappe.get_print ([#18989](#18989)) ([#19034](#19034)) ([c887be5](c887be5))
stephenBDT
pushed a commit
to alias/frappe
that referenced
this pull request
Nov 30, 2022
…#19013) * fix: Avoid `update_order` twice on kanban load - The older logic called `kanban.update()` on a refresh (not on load) and returned from `render()` - Due to a recent PR, it calls `kanban.update()` AND builds a new board on load, which invokes `update_order` twice consecutively and causes a timestamp error to be thrown * chore: Remove redundant condition Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com> (cherry picked from commit a4db455) Co-authored-by: Marica <maricadsouza221197@gmail.com>
stephenBDT
pushed a commit
to alias/frappe
that referenced
this pull request
Nov 30, 2022
# [14.17.0](frappe/frappe@v14.16.0...v14.17.0) (2022-11-29) ### Bug Fixes * Avoid `update_order` twice on Kanban load ([frappe#19011](frappe#19011)) ([frappe#19013](frappe#19013)) ([c6e2d16](frappe@c6e2d16)) * broken link for email tracking pixels ([frappe#19030](frappe#19030)) ([frappe#19032](frappe#19032)) ([ca520e0](frappe@ca520e0)) * Correctness in get_role_permissions and has_perm JS APIs (backport [frappe#18877](frappe#18877)) ([frappe#18976](frappe#18976)) ([cc2cd5f](frappe@cc2cd5f)) * default value options: sort ([frappe#19019](frappe#19019)) ([frappe#19022](frappe#19022)) ([3ec6d9c](frappe@3ec6d9c)) * discovery and styling issues in grid buttons ([a6bda7f](frappe@a6bda7f)) * handle "No Letterhead" in new print format builder ([frappe#18990](frappe#18990)) ([frappe#18992](frappe#18992)) ([1ad1cab](frappe@1ad1cab)) * horizontal scroll in rtl language ([906336e](frappe@906336e)) * only accept string values for `key` ([237a152](frappe@237a152)) * webform read only field not working ([frappe#19026](frappe#19026)) ([ce505ca](frappe@ce505ca)) * z-index for barcode and awesomeplete (backport [frappe#18893](frappe#18893)) ([frappe#19003](frappe#19003)) ([0191858](frappe@0191858)) ### Features * add param letterhead to frappe.get_print ([frappe#18989](frappe#18989)) ([frappe#19034](frappe#19034)) ([c887be5](frappe@c887be5))
stephenBDT
pushed a commit
to alias/frappe
that referenced
this pull request
Dec 1, 2022
…#19013) * fix: Avoid `update_order` twice on kanban load - The older logic called `kanban.update()` on a refresh (not on load) and returned from `render()` - Due to a recent PR, it calls `kanban.update()` AND builds a new board on load, which invokes `update_order` twice consecutively and causes a timestamp error to be thrown * chore: Remove redundant condition Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com> (cherry picked from commit a4db455) Co-authored-by: Marica <maricadsouza221197@gmail.com>
stephenBDT
pushed a commit
to alias/frappe
that referenced
this pull request
Dec 1, 2022
# [14.17.0](frappe/frappe@v14.16.0...v14.17.0) (2022-11-29) ### Bug Fixes * Avoid `update_order` twice on Kanban load ([frappe#19011](frappe#19011)) ([frappe#19013](frappe#19013)) ([c6e2d16](frappe@c6e2d16)) * broken link for email tracking pixels ([frappe#19030](frappe#19030)) ([frappe#19032](frappe#19032)) ([ca520e0](frappe@ca520e0)) * Correctness in get_role_permissions and has_perm JS APIs (backport [frappe#18877](frappe#18877)) ([frappe#18976](frappe#18976)) ([cc2cd5f](frappe@cc2cd5f)) * default value options: sort ([frappe#19019](frappe#19019)) ([frappe#19022](frappe#19022)) ([3ec6d9c](frappe@3ec6d9c)) * discovery and styling issues in grid buttons ([a6bda7f](frappe@a6bda7f)) * handle "No Letterhead" in new print format builder ([frappe#18990](frappe#18990)) ([frappe#18992](frappe#18992)) ([1ad1cab](frappe@1ad1cab)) * horizontal scroll in rtl language ([906336e](frappe@906336e)) * only accept string values for `key` ([237a152](frappe@237a152)) * webform read only field not working ([frappe#19026](frappe#19026)) ([ce505ca](frappe@ce505ca)) * z-index for barcode and awesomeplete (backport [frappe#18893](frappe#18893)) ([frappe#19003](frappe#19003)) ([0191858](frappe@0191858)) ### Features * add param letterhead to frappe.get_print ([frappe#18989](frappe#18989)) ([frappe#19034](frappe#19034)) ([c887be5](frappe@c887be5))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
kanban.update()on a refresh (not on load) and built a new board on loadkanban.update()AND builds a new board (both) on load, which invokesupdate_ordertwice consecutively and causes a timestamp error to be thrown