From 6c13a3b44b7afae0b448051ab3943f2ba75ceb88 Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Mon, 19 Feb 2024 13:33:28 +0530 Subject: [PATCH 1/2] fix: send_workflow_action_email (#24929) (#24939) * fix: send_workflow_action_email * fix: send_workflow_action_email (cherry picked from commit 15eb1bf8395e3f5f3a71e30ba3efda3a1b7010e9) Co-authored-by: Nihantra C. Patel <141945075+Nihantra-Patel@users.noreply.github.com> --- .../workflow/doctype/workflow_action/workflow_action.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/frappe/workflow/doctype/workflow_action/workflow_action.py b/frappe/workflow/doctype/workflow_action/workflow_action.py index f50c8bf6c74f..5a3ea5083976 100644 --- a/frappe/workflow/doctype/workflow_action/workflow_action.py +++ b/frappe/workflow/doctype/workflow_action/workflow_action.py @@ -308,7 +308,7 @@ def get_users_next_action_data(transitions, doc): def user_has_permission(user: str) -> bool: from frappe.permissions import has_permission - return has_permission(doctype=doc, user=user, print_logs=False) + return has_permission(doctype=doc, user=user) for transition in transitions: users = get_users_with_role(transition.allowed) @@ -359,10 +359,10 @@ def send_workflow_action_email(doc, transitions): users_data = get_users_next_action_data(transitions, doc) common_args = get_common_email_args(doc) message = common_args.pop("message", None) - for d in users_data: + for user, data in users_data.items(): # noqa: B007 email_args = { - "recipients": [d.get("email")], - "args": {"actions": list(deduplicate_actions(d.get("possible_actions"))), "message": message}, + "recipients": [data.get("email")], + "args": {"actions": list(deduplicate_actions(data.get("possible_actions"))), "message": message}, "reference_name": doc.name, "reference_doctype": doc.doctype, } From ab127f64656f87ddb4e80b21b0c08d1651daf86b Mon Sep 17 00:00:00 2001 From: Frappe PR Bot Date: Mon, 19 Feb 2024 08:04:33 +0000 Subject: [PATCH 2/2] chore(release): Bumped to Version 14.66.1 ## [14.66.1](https://github.com/frappe/frappe/compare/v14.66.0...v14.66.1) (2024-02-19) ### Bug Fixes * send_workflow_action_email ([#24929](https://github.com/frappe/frappe/issues/24929)) ([#24939](https://github.com/frappe/frappe/issues/24939)) ([6c13a3b](https://github.com/frappe/frappe/commit/6c13a3b44b7afae0b448051ab3943f2ba75ceb88)) --- frappe/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/__init__.py b/frappe/__init__.py index eda82eb984aa..d8f1154b9245 100644 --- a/frappe/__init__.py +++ b/frappe/__init__.py @@ -44,7 +44,7 @@ ) from .utils.lazy_loader import lazy_import -__version__ = "14.66.0" +__version__ = "14.66.1" __title__ = "Frappe Framework" controllers = {}