8000 Support passing in parent as dom element rather than only a string id. · Issue #40 · frappe/charts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support passing in parent as dom element rather than only a string id. #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bahrus opened this issue Nov 5, 2017 · 4 comments
Closed

Support passing in parent as dom element rather than only a string id. #40

bahrus opened this issue Nov 5, 2017 · 4 comments
Labels
question

Comments

@bahrus
Copy link
bahrus commented Nov 5, 2017

I'm working on a web component wrapper around this library. If you could support this option, life would be much easier.
@pratu16x7
Copy link
Contributor
pratu16x7 commented Nov 5, 2017 •
edited
Loading

Yep, we do, thanks to @tobiaslins
https://github.com/frappe/charts/blob/master/src/scripts/charts/BaseChart.js#L25

Ref #24 and #25 for work on this.

Have updated the docs. Cheers!

@bahrus
Copy link
Author
bahrus commented Nov 5, 2017

I guess it hasn't published to npm yet? I was referencing https://unpkg.com/frappe-charts@0.0.3/dist/frappe-charts.min.iife.js , and it still seems to have the old code.

@pratu16x7
Copy link
Contributor

Yeah we plan on publishing in some time, some refactoring on the way.

@pratu16x7 pratu16x7 mentioned this issue Nov 6, 2017
Closed
@pratu16x7
Copy link
Contributor

Published, feel free to reopen in case of issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bahrus @pratu16x7
0