8000   become   · Issue #841 · foundation/foundation-emails · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

  become   #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
afterbit01 opened this issue Oct 30, 2017 · 10 comments
Open

  become   #841

afterbit01 opened this issue Oct 30, 2017 · 10 comments

Comments

@afterbit01
Copy link

Hi,
when i use the inliner the entity " " become " "
is it right?
@bartdevuyst
Copy link
bartdevuyst commented Nov 9, 2017 •
edited
Loading

I have the same issue with the inliner. Seems like a conversion bug between the HTML name and HTML number of a non-breaking space character. &nbps; vs.  

@sollemar
Copy link

https://foundation.zurb.com/emails/inliner-v2.html
Same here

This was referenced Mar 11, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@julkue julkue mentioned this issue Apr 23, 2018
Closed
@julkue
Copy link
julkue commented Apr 23, 2018

Same as #763

@DanielRuf DanielRuf reopened this Nov 1, 2019
@DanielRuf DanielRuf mentioned this issue Nov 1, 2019
Closed
@DanielRuf DanielRuf mentioned this issue Jan 31, 2020
Closed
@DanielRuf DanielRuf reopened this Jan 31, 2020
@DanielRuf
Copy link
Contributor

Bildschirmfoto 2020-01-31 um 01 32 32

@DanielRuf
Copy link
Contributor

Not yet sure where exactly this is happening:

https://github.com/foundation/foundation-web-inliner/blob/master/lib/inline.js

@DanielRuf
Copy link
Contributor
DanielRuf commented Jan 31, 2020 •
edited
Loading

Seems it does not happen with the current status of the foundation-web-inliner project (chore/upgrade-browserify-html-minifier):

Bildschirmfoto 2020-01-31 um 01 45 41

foundation/foundation-web-inliner#3

So this should be fixed with the next deployment.

@DanielRuf
Copy link
Contributor

Old minifier from https://raw.githubusercontent.com/foundation/foundation-marketing/master/src/assets/lib/inliner.min.js

Bildschirmfoto 2020-01-31 um 01 54 18

@DanielRuf
Copy link
Contributor

I guess the html markup comes from cheerio

https://github.com/cheeriojs/cheerio/search?q=xhtml+is%3Aissue&type=Issues

@DanielRuf DanielRuf mentioned this issue Apr 2, 2020
Closed
@ghost
Copy link
8000
ghost commented Feb 11, 2021

This still seems to be an issue with the web-based inliner "copy to clipboard" button - & gets changed to & by that button. Am wondering when the fix will be released - the last discussion was about a year ago.

Thanks.

@DanielRuf DanielRuf mentioned this issue Apr 21, 2021
Closed
@DanielRuf DanielRuf pinned this issue Apr 21, 2021
@joeworkman joeworkman unpinned this issue Jun 11, 2024
@Peter-HVD
Copy link

This is still an issue. and it is definitely with the "copy to clipboard" button - if you manually select the code the ampersand is not encoded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Peter-HVD @DanielRuf @sollemar @bartdevuyst @julkue @afterbit01
0