8000 [feaLib] add support for Character Variants FeatureParams · Issue #860 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[feaLib] add support for Character Variants FeatureParams #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anthrotype opened this issue Feb 24, 2017 · 1 comment
Closed

[feaLib] add support for Character Variants FeatureParams #860

anthrotype opened this issue Feb 24, 2017 · 1 comment
Labels
enhancement

Comments

@anthrotype
Copy link
Member

feaLib currently supports featureNames tags to add FeatureParams tables to stylistic sets (ssXX) features.

To support Feature Parameters in Character Variants features (cvXX) feaLib should add support for "cvParameters":
http://www.adobe.com/devnet/opentype/afdko/topic_feature_file_syntax.html#8.d

Also see the definition from OT spec under Tag: 'cv01' - 'cv99':
https://www.microsoft.com/typography/otspec/features_ae.htm

And in otData.py:

fonttools/Lib/fontTools/ttLib/tables/otData.py

Lines 72 to 81 in 0cc1721

('FeatureParamsCharacterVariants', [
('uint16', 'Format', None, None, 'Set to 0.'),
('NameID', 'FeatUILabelNameID', None, None, 'Feature UI label NameID.'),
('NameID', 'FeatUITooltipTextNameID', None, None, 'Feature UI tooltip text NameID.'),
('NameID', 'SampleTextNameID', None, None, 'Sample text NameID.'),
('uint16', 'NumNamedParameters', None, None, 'Number of named parameters.'),
('NameID', 'FirstParamUILabelNameID', None, None, 'First NameID of UI feature parameters.'),
('uint16', 'CharCount', None, None, 'Count of characters this feature provides glyph variants for.'),
('uint24', 'Character', 'CharCount', 0, 'Unicode characters for which this feature provides glyph variants.'),
]),

@anthrotype
Copy link
Member Author

Fixed by #1169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anthrotype
0