8000 [varLib] Encode postscriptname for fvar as single-byte encoding · Issue #756 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[varLib] Encode postscriptname for fvar as single-byte encoding #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
behdad opened this issue Dec 1, 2016 · 8 comments
Closed

[varLib] Encode postscriptname for fvar as single-byte encoding #756

behdad opened this issue Dec 1, 2016 · 8 comments
Assignees
@behdad

Comments

@behdad
Copy link
Member
behdad commented Dec 1, 2016

For example, MacRoman. Apparently OS X implementation requires that they be encoded using single-byte encoding (and be unique).
@behdad
Copy link
Member Author
behdad commented Dec 1, 2016

cc @rsheeter

@behdad behdad self-assigned this Dec 1, 2016
@anthrotype
Copy link
Member

We already write the fvar postscript font name as both single-byte MacRoman (1, 0, 0) and Windows Unicode (3, 1, 0x409) name records:
https:// 8000 github.com/fonttools/fonttools/blob/master/Lib/fontTools/varLib/__init__.py#L77

We added a addName method to the name table to do just that:
https://github.com/fonttools/fonttools/blob/master/Lib/fontTools/ttLib/tables/_n_a_m_e.py#L148

When you say "unique", you mean OSX doesn't like that that we also write a windows-unicode one?

@anthrotype
Copy link
Member

See related issue #683 (closed)

@behdad
Copy link
Member Author
behdad commented Dec 5, 2016

Right. Ok. Thanks.

@behdad
Copy link
Member Author
behdad commented Dec 17, 2016

Let's close then.

@behdad behdad closed this as completed Dec 17, 2016
@behdad behdad reopened this Dec 17, 2016
@behdad
Copy link
Member Author
behdad commented Dec 17, 2016

It is a problem though that subsetter by default removes the macroman names.

@anthrotype
Copy link
Member

It is a problem though that subsetter by default removes the macroman names.

I guess we should open a separate issue for this.

@brawer brawer mentioned this issue Mar 9, 2017
Open
@brawer
Copy link
Collaborator
brawer commented Mar 9, 2017

It is a problem though that subsetter by default removes the macroman names.

I guess we should open a separate issue for this.

Seems related to #146 so I’ve added it there.

@brawer brawer closed this as completed Mar 9, 2017
@anthrotype anthrotype mentioned this issue Mar 31, 2017
Closed
@anthrotype anthrotype mentioned this issue Sep 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@behdad behdad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@behdad @brawer @anthrotype
0