8000 [feaLib] "fonttools feaLib" should error out, not continue · Issue #2459 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[feaLib] "fonttools feaLib" should error out, not continue #2459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
simoncozens opened this issue Dec 2, 2021 · 0 comments · Fixed by #2472
Closed

[feaLib] "fonttools feaLib" should error out, not continue #2459

simoncozens opened this issue Dec 2, 2021 · 0 comments · Fixed by #2472

Comments

@simoncozens
Copy link
Collaborator

If there's a parse/build error when using the feaLib command line tool, we currently do this:

fonttools/Lib/fontTools/feaLib/__main__.py

Lines 69 to 73 in 445108f

except FeatureLibError as e:
if options.traceback:
raise
log.error(e)
font.save(output_font)

i.e. we save the font anyway and exit with status code 0.

My Makefiles and I think this is a terrible idea, and I would like to change it. Any objections / thoughts?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[feaLib] Fail with error code when buil 2E3E d fails simoncozens/fonttools
1 participant
@simoncozens
0