8000 [shared_preferences] Endorse Windows by stuartmorgan-g · Pull Request #3059 · flutter/plugins · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[shared_preferences] Endorse Windows #3059

Conversation

stuartmorgan-g
Copy link
Contributor
@stuartmorgan-g stuartmorgan-g commented Sep 20, 2020

Description

Adds endorsement, and manual registration, of
shared_preferences_windows.

Related Issues

Fixes flutter/flutter#41719

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Adds endorsement, and manual registration, of
shared_preferences_windows.

Fixes flutter/flutter#41719
@stuartmorgan-g
Copy link
Contributor Author
stuartmorgan-g commented Sep 20, 2020

This will fail tests until #3058 lands so I can publish path_provider_windows, but I wanted to get it reviewed in parallel to save time.

path_provider_windows is now published, so this is unblocked.

Copy link
Contributor
@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@stuartmorgan-g stuartmorgan-g merged commit fce1eee into flutter:master Sep 22, 2020
@stuartmorgan-g stuartmorgan-g deleted the shared-preferences-endorse-windows branch September 22, 2020 10:27
@technolion
Copy link
Contributor

Great work, thanks. This was an important missing piece for Windows!

danielroek pushed a commit to Baseflow/flutter-plugins that referenced this pull request Oct 1, 2020
Adds endorsement, and manual registration, of
shared_preferences_windows.

Fixes flutter/flutter#41719
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
Adds endorsement, and manual registration, of
shared_preferences_windows.

Fixes flutter/flutter#41719
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Adds endorsement, and manual registration, of
shared_preferences_windows.

Fixes flutter/flutter#41719
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[shared_preferences] Add Windows support
4 participants
0