8000 flutter_plugins analyze shard is failing with path_provider_windows analyzer warning 'unpackString' is deprecated and shouldn't be used · Issue #75890 · flutter/flutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

flutter_plugins analyze shard is failing with path_provider_windows analyzer warning 'unpackString' is deprecated and shouldn't be used #75890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jmagman opened this issue Feb 12, 2021 · 5 comments
Closed

flutter_plugins analyze shard is failing with path_provider_windows analyzer warning 'unpackString' is deprecated and shouldn't be used #75890

jmagman opened this issue Feb 12, 2021 · 5 comments
Labels
a: tests "flutter test", flutter_test, or one of our tests p: path_provider Plugin that provides resolved paths to some platform directories P0 Critical issues such as a build break or regression package flutter/packages repository. See also p: labels.

Comments

@jmagman
Copy link
Member
jmagman commented Feb 12, 2021

Tree is closed on flutter_plugins error.

Checking project path_provider_windows...

  info - 'unpackString' is deprecated and shouldn't be used at lib/src/path_provider_windows_real.dart:37:33 - (deprecated_member_use)
  info - 'unpackString' is deprecated and shouldn't be used at lib/src/path_provider_windows_real.dart:67:23 - (deprecated_member_use)
  info - 'unpackString' is deprecated and shouldn't be used at lib/src/path_provider_windows_real.dart:135:37 - (deprecated_member_use)
  info - 'unpackString' is deprecated and shouldn't be used at lib/src/path_provider_windows_real.dart:187:30 - (deprecated_member_use)
...
The following packages have analyzer errors (see above):
 * path_provider_windows

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8855548098372693696/+/steps/run_test.dart_for_flutter_plugins_shard_and_subshard_analyze/0/stdout

I reproduced this locally as well.
@jmagman jmagman added a: tests "flutter test", flutter_test, or one of our tests plugin P0 Critical issues such as a build break or regression labels Feb 12, 2021
@jmagman
Copy link
Member Author
jmagman commented Feb 12, 2021

When I ran it locally the pubspec.lock shows win32 at 2.0.0-nullsafety.12

  win32:
    dependency: "direct main"
    description:
      name: win32
      url: "https://pub.dartlang.org"
    source: hosted
    version: "2.0.0-nullsafety.12"

@jmagman
Copy link
Member Author
jmagman commented Feb 12, 2021

I guess path_provider_windows pubspec.yaml needs to be pinned to < 2.0.0-nullsafety.12 where this was deprecated \cc @timsneath halildurmus/win32@3938010

https://github.com/flutter/plugins/blob/master/packages/path_provider/path_provider_windows/pubspec.yaml#L20

  win32: ^2.0.0-nullsafety.10

@jmagman jmagman added the p: path_provider Plugin that provides resolved paths to some platform directories label Feb 12, 2021
@timsneath
Copy link
Contributor

Yup -- pending PR here:
flutter/plugins#3540

The breaking change is in ffi, not win32...

@jmagman
Copy link
Member Author
jmagman commented Feb 12, 2021

flutter/plugins#3540 was merged. Should be fixed with plugins roll #75891.

@jmagman jmagman closed this as completed Feb 12, 2021
@github-actions
Copy link
github-actions bot commented Aug 5, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests p: path_provider Plugin that provides resolved paths to some platform directories P0 Critical issues such as a build break or regression package flutter/packages repository. See also p: labels.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmagman @timsneath
0