8000 Use Dart's lightweight isolates between multiple engines · Issue #72025 · flutter/flutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use Dart's lightweight isolates between multiple engines #72025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xster opened this issue Dec 9, 2020 · 5 comments · Fixed by flutter/engine#23782
Closed

Use Dart's lightweight isolates between multiple engines #72025

xster opened this issue Dec 9, 2020 · 5 comments · Fixed by flutter/engine#23782
Assignees
@gaaclarke
Labels
dependency: dart Dart team may need to help us engine flutter/engine repository. See also e: labels. P1 High-priority issues at the top of the work list platform-android Android applications specifically platform-ios iOS applications specifically
Milestone
January Beta Rele...

Comments

@xster
Copy link
Member
xster commented Dec 9, 2020

Let the APIs built from dart-lang/sdk#36097 be used to create lightweight isolates in engines of the same FlutterEngineGroup on Android and iOS.

If JIT execution isn't ready, make sure to have a graceful fallback.
@xster xster added platform-android Android applications specifically platform-ios iOS applications specifically engine flutter/engine repository. See also e: labels. dependency: dart Dart team may need to help us labels Dec 9, 2020
@xster xster mentioned this issue Dec 9, 2020
Closed
29 tasks
@xster xster added the P1 High-priority issues at the top of the work list label Dec 10, 2020
@gaaclarke gaaclarke mentioned this issue Jan 8, 2021
Merged
13 tasks
@gaaclarke gaaclarke mentioned this issue Jan 20, 2021
Merged
9 tasks
@xster xster added this to the January Beta Release (1.26) milestone Jan 22, 2021
@xster
Copy link
Member Author
xster commented Jan 29, 2021

Re-opening. Seems like isolate group re-use isn't working on Android.

@xster xster reopened this Jan 29, 2021
@xster
Copy link
Member Author
xster commented Jan 29, 2021 •
edited
Loading

Trying on iOS on https://github.com/gaaclarke/DoubleEngine with the engine on master head doesn't seem to be triggering https://github.com/flutter/engine/blob/ce14c8a8414214b0afc3e4c9bec8d6538bf72323/runtime/dart_isolate.cc#L278 instead of https://github.com/flutter/engine/blob/ce14c8a8414214b0afc3e4c9bec8d6538bf72323/runtime/dart_isolate.cc#L265 as well.

Maybe we're missing a flag? https://cs.opensource.google/search?q=%22--enable_isolate_groups%22&sq=&ss=flutter.

This could plausibly explain our memory discrepancy with the prototype.

@gaaclarke
Copy link
Member

(mentioned offline in a chat)

This is the conditional that determines if we are using CreateIsolateInGroup: https://github.com/flutter/engine/blob/0317e389fc07a98bd01775c42f410b6980dfe50e/runtime/dart_isolate.cc#L259

I'd print that out that conditional. We have unit tests that are asserting that CreateIsolateInGroup is being used when possible.

@gaaclarke gaaclarke mentioned this issue Feb 1, 2021
Merged
9 tasks
@xster xster closed this as completed Feb 2, 2021
@xster xster added the cp: 1.26 label Feb 2, 2021
@xster
Copy link
Member Author
xster commented Feb 2, 2021

Verified on memory. This fix is correct! The memory overhead per engine is just 180kB now \o/

@xster xster mentioned this issue Feb 2, 2021
Merged
11 tasks
@christopherfujino christopherfujino mentioned this issue Feb 9, 2021
Merged
936B 5 tasks
@github-actions
Copy link
github-actions bot commented Aug 5, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gaaclarke gaaclarke

Labels
dependency: dart Dart team may need to help us engine flutter/engine repository. See also e: labels. P1 High-priority issues at the top of the work list platform-android Android applications specifically platform-ios iOS applications specifically
Projects
None yet
Milestone
January Beta Release (1.26)
Development

Successfully merging a pull request may close this issue.

Started using Dart_CreateInGroup when using spawn on a release build gaaclarke/engine
4 participants
@xster @gaaclarke @pcsosinski @pedromassangocode
0