[integration_test] Needs null safety migration #71379
Comments
|
This was being worked in flutter/plugins#3158 but according to flutter/plugins#3158 (comment) the package is being moved to flutter repository so not really sure if this was already addressed or not. |
|
This is blocked by migrating package:vm_service. |
|
package:vm_service is basically ready to go, but there's a bit of a dance we need to do in order to land. We'll need to also migrate package:dwds and likely DevTools to null safety. @devoncarew, is there anything else I've missed here? |
|
Those are the bigger users that I'm aware of. The rollout could probably do with a little planning - perhaps in an issue at flutter/devtools? Specifically:
DevTools does want to be able to ship to older stable SDKs (2.10 say).The web app has a dep on vm_service (https://github.com/flutter/devtools/blob/master/packages/devtools_app/pubspec.yaml#L41). We can likely develop that against a dev sdk - the compiled output is used by the user, not the devtools_app package itself. The devtools server also has a dep on vm_service (https://github.com/flutter/devtools/blob/master/packages/devtools_server/pubspec.yaml#L26). We likely couldn't move that dep to the null safe one until we no longer need to support 2.10 for new devtools releases. cc @grouma @kenzieschmoll for dwds and devtools planning here |
Although not a deal breaker, this puts
@bkonyi I think it's worth setting up a quick sync to ensure we are all on the same page here. |
|
To close the loop here, given that several different packages and tools have tight version range deps on package:vm_service, it may be useful if this particular reference to it was in-lined. This file: https://github.com/flutter/plugins/blob/master/packages/integration_test/lib/integration_test.dart seems to make light use of the library, so could just as easily use a small, hand-written wrapper that speaks to the VM via sending and receiving the json RPC calls. |
|
flutter_tools also will want to migrate to null safety at some point, and also depends on vm_service. integration_test only makes light use, but flutter_driver makes heavier use, and integration test has dependencies on flutter_driver. We could just avoid using vm_service, but we'd basically be re-implementing it there, and it's not a completely trivial task. |
This shouldn't be on the critical path though? We should be able to wait until the next stable release. |
|
No, flutter_tools is separate from this completely. But flutter_driver is not separate. What's the timeline for the next stable release that would make all of this easier? |
|
@grouma @bkonyi @devoncarew - to clarify again, in case I haven't made it clear enough: It would really help to have a clearer timeline (in this bug or a doc/sheet or somewhere) that we can follow to know when this gets unblocked and what its current status is. If this really is blocked until the next stable release of Dart, it'd be good to know what the date (or at least the estimated date) is for that. /cc @csells |
|
Thanks for raising your concerns @dnfield. I was under the impression that Devon's suggestion was sufficient. I set up a sync so we can better coordinate the |
|
This is currently blocking #67447. |
|
FYI, @bkonyi has migrated package:vm_service to null safety; https://pub.dev/packages/vm_service @ |
|
This is great news! Thanks @bkonyi!!! |
|
I didn't want to kick up any more dust in this thread, but we are also not willing to track |
Given the announcement at https://medium.com/dartlang/preparing-the-dart-and-flutter-ecosystem-for-null-safety-e550ce72c010 that is asking package authors to publish their null safety versions to stable, is this still the case? I recently filed an issue on the |
There's a sweep that just started recently over flutter/plugins to make sure all the |
|
@stuartmorgan yes it is indeed but what I forgot to add was that even after migrating the example app, I noticed that integration test wouldn't crash due to issues in the plugin. I was hoping the integration test would catch the issue with the plugin but perhaps I've missed something here on how to get there integration test run in strong mode |
|
@dnfield what's the proper way to use As that is still importing the non null-safety version Thank you! |
See #71379 (comment) for the reference format. |
|
Awesome thank you @stuartmorgan that worked and happy to confirm that the current |
|
@stuartmorgan Would you know the best way to track when integration_test and/or flutter_driver would be available on beta? Is it reasonable to have an issue dedicated to that? Is #77459 likely to get a ping when they're on beta? |
When a 2.1.0-* version is released to beta.
Issues reflect the state of master, not release channels, so no.
There is no mechanism for automatically pinging old bugs when their fixes reach other channels. Someone in the community is welcome to do so if they like. |
|
Tests and NNBD are both very important. So we need to have tests as well as nnbd (and a stable channel - since the app is in production). Is there any workaround, or we have to wait 3 months until the next stable release? Thanks |
|
In my case, the problem is not simply "the test code needs to be non-null-safe", but my whole app cannot work! :( details: #82419 and StackOverflow |
|
Any updates on this? This is blocking |
|
This is available on the beta channel and will be in the next stable release. |
|
Error: Cannot run with sound null safety, because the following dependencies
For solutions, see https://dart.dev/go/unsound-null-safety :( :( |
|
Nullsafe integration_test is available on the stable channel - please upgrade if you're still seeing this. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Uh oh!
There was an error while loading. Please reload this page.
Because many plugins depend on
integration_testin order to do their testing, the package should be migrated to support null safety.https://pub.dev/packages/integration_test
The text was updated successfully, but these errors were encountered: