8000 Update st, abc, el, and travis.sh to pass travis tests by snozawa · Pull Request #903 · fkanehiro/hrpsys-base · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update st, abc, el, and travis.sh to pass travis tests #903

Merged
merged 6 commits into from
Dec 13, 2015
Merged

Update st, abc, el, and travis.sh to pass travis tests #903

merged 6 commits into from
Dec 13, 2015

Conversation

snozawa
Copy link
Contributor
@snozawa snozawa commented Dec 13, 2015

travisのテストが通らないorとおりにくい箇所を直しました。
#900
を含んでいます。
travsiで確認中なので、まだマージしないようよろしくお願いいたします。

@snozawa
[rtc/Stabilizer/Stabilizer.*] Update Stabilizer doc including paper n…
579eb86 
…ames and equation numbers.
@snozawa
[sample/SampleRobot/samplerobot_auto_balancer.py] Use abs for Base RP…
e970cf0 
…Y error checking and check base RPY error between reference and actual.
@snozawa
[rtc/AutoBalancer/AutoBalancer.cpp] Revert AutoBalancer 7a8bc67 chang…
ad4eb10 
…e which does not pass samplerobot_auto_balancer.py test.
8000 @snozawa
[sample/SampleRobot/samplerobot_soft_error_limiter.py] Use getActualS…
f2970b3 
…tate().command instead of rtm.readDataPort of el joint angle output to keep thread safety.
@snozawa
[.travis.sh] Add inputting of N for mongodb configuration during deb …
9dad254 
…install reported in fkanehiro#900 (comment)
@k-okada
Copy link
Contributor
k-okada commented Dec 13, 2015

Refer to this link for build results (access rights to CI server needed):
http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2456/

Build Log
last 10 lines

[...truncated 3676 lines...]
    at org.jenkinsci.plugins.ghprb.GhprbRepository.createCommitStatus(GhprbRepository.java:122)
    at org.jenkinsci.plugins.ghprb.GhprbBuilds.onCompleted(GhprbBuilds.java:118)
    at org.jenkinsci.plugins.ghprb.GhprbBuildListener.onCompleted(GhprbBuildListener.java:27)
    at org.jenkinsci.plugins.ghprb.GhprbBuildListener.onCompleted(GhprbBuildListener.java:12)
    at hudson.model.listeners.RunListener.fireCompleted(RunListener.java:201)
    at hudson.model.Run.execute(Run.java:1783)
    at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
    at hudson.model.ResourceController.execute(ResourceController.java:98)
    at hudson.model.Executor.run(Executor.java:410)

Test FAILed.

@k-okada
Copy link
Contributor
k-okada commented Dec 13, 2015

Refer to this link for build results (access rights to CI server needed):
http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2457/

Build Log
last 10 lines

[...truncated 3676 lines...]
    at org.jenkinsci.plugins.ghprb.GhprbRepository.createCommitStatus(GhprbRepository.java:122)
    at org.jenkinsci.plugins.ghprb.GhprbBuilds.onCompleted(GhprbBuilds.java:118)
    at org.jenkinsci.plugins.ghprb.GhprbBuildListener.onCompleted(GhprbBuildListener.java:27)
    at org.jenkinsci.plugins.ghprb.GhprbBuildListener.onCompleted(GhprbBuildListener.java:12)
    at hudson.model.listeners.RunListener.fireCompleted(RunListener.java:201)
    at hudson.model.Run.execute(Run.java:1783)
    at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
    at hudson.model.ResourceController.execute(ResourceController.java:98)
    at hudson.model.Executor.run(Executor.java:410)

Test FAILed.

@snozawa
Copy link
Contributor Author
snozawa commented Dec 13, 2015

変更内容についてのメモです。

  • abcのテストが不十分で、適切にうごいてなくてもテストが通ってましたので、samplerobot_auto_balacer.pyを修正してテストが通らないようにしました(倒れた判定でabsをとるひつようがあった)。
  • @eisoku9618 さん。上記を直した上で、eisoku9618@7a8bc67 の内容が通ってなかったようなのでrevertしました。
  • elで、readDataPortでなくて落ちていたので、getActualStateをつかうようにしました。

@snozawa
Copy link
Contributor Author
snozawa commented Dec 13, 2015

確認できてtravisも通りましたので、mergeいただけますと助かります

fkanehiro added a commit that referenced this pull request Dec 13, 2015
@fkanehiro
Merge pull request #903 from snozawa/update_st_abc_el
bd0b2a2 
Update st, abc, el, and travis.sh to pass travis tests
@fkanehiro fkanehiro merged commit bd0b2a2 into fkanehiro:master Dec 13, 2015
k-okada
k-okada reviewed Dec 14, 2015
View reviewed changes
.travis.sh
@@ -180,7 +180,8 @@ case $TEST_PACKAGE in
pkg=$TEST_PACKAGE
sudo apt-get install -qq -y python-wstool ros-hydro-catkin ros-hydro-mk ros-hydro-rostest ros-hydro-rtmbuild ros-hydro-roslint > /dev/null

sudo apt-get install -qq -y ros-hydro-pcl-ros ros-hydro-moveit-commander ros-hydro-rqt-robot-dashboard > /dev/null
# Add inputting of "N" for mongodb configuration during deb install reported in https://github.com/fkanehiro/hrpsys-base/pull/900#issuecomment-162392884
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

そうですね．
https://s3.amazonaws.com/archive.travis-ci.org/jobs/95277537/log.txt
mongo dbの部分は実行されてそうでした．

apt-get remove ではなくて，apt-get purgeにしたらいいんじゃないかと思う．
yes N　.. はいろいろ危険なきがする．

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#906
で確認中です。

ところでこれはなぜ必要なんでしたっけ。
travisでpre installされて使われているmongodbと、他で使っている（今回はたmたまmoveit-commander）mongodbとでバージョンが違うのでしょうか。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Mon, Dec 14, 2015 at 12:24 PM, Shunichi Nozawa notifications@github.com
wrote:

travisでpre
installされて使われているmongodbと、他で使っている（今回はたmたまmoveit-commander）mongodbとでバージョンが違うのでしょうか。

ああ，なるほど．そうかもしれないですね．

◉ Kei Okada

@snozawa snozawa mentioned this pull request Dec 14, 2015
Merged
@snozawa snozawa deleted the update_st_abc_el branch December 14, 2015 13:33
@snozawa snozawa mentioned this pull request Dec 14, 2015
Closed
@eisoku9618 eisoku9618 mentioned this pull request Dec 18, 2015
Merged
@coveralls
Copy link
coveralls commented Oct 30, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling 676bac4 on snozawa:update_st_abc_el into ** on fkanehiro:master**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@snozawa @k-okada @coveralls @fkanehiro
0