Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 6 commits
- 55 files changed
- 3 contributors
Commits on Mar 17, 2025
-
Fix date filters in perspective-{select,click} events
Fixes issue #2949 where date filters in the `perspective-select` and `perspective-click` events use a zero-indexed month, but the date filter input uses a one-indexed month. The date filter returned by `perspective-config-update` is correctly one-indexed. This issue makes the filtered data in a workspace incorrect. It also makes perspective crash if a January 1 date gets converted to `2025-00-01` and then passed to a second view. Fix this by simply adding 1 to the month when generating the config in `ProtoServer::_handle_request`. Signed-off-by: Nicholas Burlett <nburlett@ghs.com>
Commits on Mar 19, 2025
-
Add test for perspective-click date bug
Regression test for issue #2949 where date filters are not correctly formatted on the perspective-click and perspective-select custom events. The test only exercises perspective-click for simplicity. A new all-types-small-multi-arrow-test.html was necessary, as the issue only affects the date datatype, and the existing csv tests only exercise the datetime data type. Signed-off-by: Nicholas Burlett <nburlett@ghs.com>
-
Invalidate session before loading
This fixes a bug where a failed `viewer.load()` call would poison the viewer and prevent it from loading any more tables. Signed-off-by: Tom Jakubowski <tom@prospective.dev>
Commits on Mar 20, 2025
-
Merge pull request #2958 from tomjakubowski/bugfix/viewer-error-recovery
Invalidate viewer session before loading table
-
Merge pull request #2957 from nburlett/master
Fix date filters in perspective-{select,click} events
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v3.4.2...v3.4.3