fibjs
diff --git a/‎fibjs/src/crypto/PKey.cpp
Lines changed: 2 additions & 2 deletions b/‎fibjs/src/crypto/PKey.cpp
Lines changed: 2 additions & 2 deletions
diff --git a/‎test/crypto_test.js
Lines changed: 6 additions & 0 deletions b/‎test/crypto_test.js
Lines changed: 6 additions & 0 deletions
@@ -27,7 +27,7 @@ result_t PKey_base::_new(Buffer_base* DerKey, exlib::string password, obj_ptr<PK
     if (hr >= 0)
         retVal->wrap();
 
-    return 0;
+    return hr;
 }
 
 result_t PKey_base::_new(exlib::string pemKey, exlib::string password, obj_ptr<PKey_base>& retVal,
@@ -37,7 +37,7 @@ result_t PKey_base::_new(exlib::string pemKey, exlib::string password, obj_ptr<P
     if (hr >= 0)
         retVal->wrap();
 
-    return 0;
+    return hr;
 }
 
 result_t PKey_base::_new(v8::Local<v8::Object> jsonKey, obj_ptr<PKey_base>& retVal,
 
@@ -1050,6 +1050,12 @@ describe('crypto', () => {
             pk = crypto.PKey.from(sm2_pem);
             assert.equal(pk.curve, 'SM2');
         });
+
+        it("BUG: crash when new PKey with empty string", () => {
+            assert.throws(() => {
+                new crypto.PKey('');
+            });
+        });
     });
 
     describe("ed25519", () => {
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ result_t PKey_base::_new(Buffer_base* DerKey, exlib::string password, obj_ptr<PK`
`27`	`27`	`if (hr >= 0)`
`28`	`28`	`retVal->wrap();`
`29`	`29`
`30`		`- return 0;`
	`30`	`+ return hr;`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`result_t PKey_base::_new(exlib::string pemKey, exlib::string password, obj_ptr<PKey_base>& retVal,`
`@@ -37,7 +37,7 @@ result_t PKey_base::_new(exlib::string pemKey, exlib::string password, obj_ptr<P`
`37`	`37`	`if (hr >= 0)`
`38`	`38`	`retVal->wrap();`
`39`	`39`
`40`		`- return 0;`
	`40`	`+ return hr;`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`result_t PKey_base::_new(v8::Local<v8::Object> jsonKey, obj_ptr<PKey_base>& retVal,`