Description
I recently stumbled across this gem, and noticed that you are using a custom implementation of Faker::String.from_regexp to generate strings from a regular expression:
Lines 19 to 28 in 49d2226
This implementation is OK for the basics, but is far from comprehensive! There is an open issue about one such bug, and another open issue that's apparently unresolved.
The regexp language is vast and complicated; solving this problem for all possible regular expressions is far from easy. However, this library provides a much more complete solution. For backwards compatibility, you could implement this as:
module FFaker
module String
def self.from_regexp(exp)
puts 'Warning: FFaker::String.from_regexp is deprecated. Use exp.random_example'
exp.random_example
end
end
end
There are a couple of potential minor issues we could discuss before dropping in this replacement (e.g. Regexp#random_example could be a refinement instead of a global class extension?), but more the most part it should be a very simple change.