Unable to encode and decode fiscal codes when year of birth (excluding century) < 10 (eg. 2004) #79

deltaredentertainment · 2023-03-29T17:33:29Z

Python version
3.9

Current behavior (bug description)
When calling both the .encode and .decode function with any birthplace it raises a ValueError:
Traceback (most recent call last):
File "/Users/davideramondetti/..../handler.py", line 19, in
cod1 = codicefiscale.decode(
File "/Users/davideramondetti/.../venv/lib/python3.9/site-packages/codicefiscale/codicefiscale.py", line 485, in decode
raise ValueError(f"[codicefiscale] wrong birthplace code: {birthplace_code!r}")
ValueError: [codicefiscale] wrong birthplace code: 'L219'

Expected behavior
It is expected for the .decode to return the extracted data, and for the Encode to output the fiscal code.

fabiocaccamo · 2023-03-29T20:25:49Z

@deltaredentertainment Could you tell me the input arguments you are using for both, encoding and decoding?

deltaredentertainment · 2023-03-29T20:30:22Z

certamente, here is a copy of the code used for trial:

`
from codicefiscale import codicefiscale

cod = codicefiscale.encode(
lastname="Rossi",
firstname="Mario",
gender="M",
birthdate="29/11/2004",
birthplace="Torino",
)

cod1 = codicefiscale.decode(
"RSSMRA00S29L219C"
)

print(cod1)
print(cod)
and here is the error:
site-packages/codicefiscale/codicefiscale.py", line 408, in encode
decode(code)
line 485, in decode
raise ValueError(f"[codicefiscale] wrong birthplace code: {birthplace_code!r}")
ValueError: [codicefiscale] wrong birthplace code: 'L219'`

Thanks!

deltaredentertainment · 2023-03-29T20:31:29Z

I have forgot to mention that it gives the error for both encode and decode

fabiocaccamo · 2023-03-29T20:36:38Z

Thank you!
That birthplace code is correct and I'm also sure that it has been used in the test suite.

I will try to replicate the error.

deltaredentertainment · 2023-03-29T20:53:23Z

i tried even with others, but it keeps resulting in the same error. Let me know, thanks.

deltaredentertainment · 2023-03-30T10:13:43Z

Dear Fabio,
I have downloaded the previous version (0.6.1) and now is working properly.
Regards,
DR

fabiocaccamo · 2023-03-30T11:31:10Z

@deltaredentertainment Looking at the cause of the problem I don't understand how the previous version can work well for you.

Anyway... this is fixed now, you can upgrade to 0.7.1 version.

deltaredentertainment · 2023-03-30T19:09:30Z

thanks, it works.

deltaredentertainment added the bug Something isn't working label Mar 29, 2023

deltaredentertainment assigned fabiocaccamo Mar 29, 2023

fabiocaccamo changed the title ~~Unable to encode and decode fiscal codes~~ Unable to encode and decode fiscal codes when year of birth (excluding century) < 10 -> eg. 2004 Mar 30, 2023

fabiocaccamo changed the title ~~Unable to encode and decode fiscal codes when year of birth (excluding century) < 10 -> eg. 2004~~ Unable to encode and decode fiscal codes when year of birth (excluding century) < 10 (eg. 2004) Mar 30, 2023

fabiocaccamo added this to Open Source Mar 30, 2023

fabiocaccamo moved this to In Progress in Open Source Mar 30, 2023

fabiocaccamo added a commit that referenced this issue Mar 30, 2023

Fix encoding/decoding error when year of birth < 10. #79

639ffb8

fabiocaccamo closed this as completed Mar 30, 2023

github-project-automation bot moved this from In Progress to Done in Open Source Mar 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unable to encode and decode fiscal codes when year of birth (excluding century) < 10 (eg. 2004) #79

Unable to encode and decode fiscal codes when year of birth (excluding century) < 10 (eg. 2004) #79

Unable to encode and decode fiscal codes when year of birth (excluding century) < 10 (eg. 2004) #79

Unable to encode and decode fiscal codes when year of birth (excluding century) < 10 (eg. 2004) #79

Comments