8000 [Fiber] Error handling · Issue #8181 · facebook/react · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Fiber] Error handling #8181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 of 4 tasks
gaearon opened this issue Nov 2, 2016 · 1 comment
Closed
2 of 4 tasks

[Fiber] Error handling #8181

gaearon opened this issue Nov 2, 2016 · 1 comment
Assignees
@gaearon

Comments

@gaearon
Copy link
Collaborator
gaearon commented Nov 2, 2016 •
edited
Loading

Filing this as a todo list for myself.
@gaearon gaearon self-assigned this Nov 2, 2016
@gaearon gaearon mentioned this issue Nov 2, 2016
Merged
6 tasks
@rthor rthor mentioned this issue Nov 8, 2016
Merged
@sebmarkbage
Copy link
Collaborator

Do you want to add "Error handling when an error is thrown in detachRef callbacks" from the umbrella? Maybe we're happy with how it works already. However, I believe this case might be problematic: return <ErrorBoundary><div ref={n => n.width} /><div ref={n => this.b = n} /></ErrorBoundary>; since during unmount the first will throw, and the second won't be cleaned up.

@gaearon gaearon closed this as completed Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaearon gaearon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebmarkbage @gaearon
0