dynamic.h operator== claiming to do a deep equal comparison but its not

In the json/dynamic.h its saying that the equal operator will do a deep equal comparison:

Lines 293 to 301 in 08d6d55

    
             /** 
        
              * Deep equality comparison.  This will compare all the way down 
        
              * an object or array, and is potentially expensive. 
        
              * 
        
              * NOTE: Implicit conversion will be done between ints and doubles, so numeric 
        
              * equality will apply between those cases. Other dynamic value comparisons of 
        
              * different types will always return false. 
        
              */ 
        
             friend bool operator==(dynamic const& a, dynamic const& b);

but looking into the implementation if the types are matching its just comparing the address:

folly/folly/json/dynamic.cpp

Lines 119 to 131 in 08d6d55

    
           bool operator==(dynamic const& a, dynamic const& b) { 
        
             if (a.type() != b.type()) { 
        
               if (a.isNumber() && b.isNumber()) { 
        
                 auto& integ = a.isInt() ? a : b; 
        
                 auto& doubl = a.isInt() ? b : a; 
        
                 return integ.asInt() == doubl.asDouble(); 
        
               } 
        
               return false; 
        
             } 
        
           #define FB_X(T) return *a.getAddress<T>() == *b.getAddress<T>(); 
        
             FB_DYNAMIC_APPLY(a.type_, FB_X); 
        
           #undef FB_X

Maybe I am missing something but it seems to me that his is incorrect and no actual deep equal comparison? (I am looking for a built-in way to do a deep equal compare)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	/**
	* Deep equality comparison. This will compare all the way down
	* an object or array, and is potentially expensive.
	*
	* NOTE: Implicit conversion will be done between ints and doubles, so numeric
	* equality will apply between those cases. Other dynamic value comparisons of
	* different types will always return false.
	*/
	friend bool operator==(dynamic const& a, dynamic const& b);

	bool operator==(dynamic const& a, dynamic const& b) {
	if (a.type() != b.type()) {
	if (a.isNumber() && b.isNumber()) {
	auto& integ = a.isInt() ? a : b;
	auto& doubl = a.isInt() ? b : a;
	return integ.asInt() == doubl.asDouble();
	}
	return false;
	}

	#define FB_X(T) return a.getAddress<T>() == b.getAddress<T>();
	FB_DYNAMIC_APPLY(a.type_, FB_X);
	#undef FB_X

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions