8000 Regression: As of d48c8ba FastClick no longer cancels clicks on scroll · Issue #116 · ftlabs/fastclick · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jun 9, 2022. It is now read-only.
This repository was archived by the owner on Jun 9, 2022. It is now read-only.
Regression: As of d48c8ba FastClick no longer cancels clicks on scroll #116
Closed
@matthew-andrews

Description

@matthew-andrews

Regression: As of d48c8ba FastClick no longer cancels clicks on scroll.

http://dev.labs.ft.com/matthew/testcase/android-regression.mov

d48c8ba

We've only noticed this being an issue on Android (scrolling clickable lists sometimes causes unwanted clicks to fire) but we suspect that is because our use of heavy reliance of ft scroller on iOS, which inadvertently fixes this issue.

We discussed two approaches:

  • either detecting when the user is scrolling, which is difficult when it's in a overflow: scroll (or when synthesising scrolling);
  • or on touchmove (as per before), which I understand may have some other implications on performance.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0