8000 [nitpick] The reserve call is repeated in multiple branches within APINoiseFrameHelper::write_raw_. Consider extracting this duplicated logic into a helper function to make the code easier to maintain. · Issue #7003 · esphome/issues · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[nitpick] The reserve call is repeated in multiple branches within APINoiseFrameHelper::write_raw_. Consider extracting this duplicated logic into a helper function to make the code easier to maintain. #7003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bdraco opened this issue May 8, 2025 · 1 comment · Fixed by esphome/esphome#8717
Closed

[nitpick] The reserve call is repeated in multiple branches within APINoiseFrameHelper::write_raw_. Consider extracting this duplicated logic into a helper function to make the code easier to maintain. #7003

bdraco opened this issue May 8, 2025 · 1 comment · Fixed by esphome/esphome#8717

Comments

@bdraco
Copy link
Member
bdraco commented May 8, 2025 
          [nitpick] The reserve call is repeated in multiple branches within APINoiseFrameHelper::write_raw_. Consider extracting this duplicated logic into a helper function to make the code easier to maintain.

Originally posted by @Copilot in esphome/esphome#8716 (comment)
@bdraco
Copy link
Member Author
bdraco commented May 8, 2025

write_raw_ is very must duplicated between noise and plaintext, it would be a good idea to reduce the duplication.

This was referenced May 8, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consolidate write_raw_ implementation to reduce code duplication esphome/esphome
1 participant
@bdraco
0