[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Run tests on Node.js v14 #13210

Merged
merged 4 commits into from
Apr 23, 2020
Merged

Chore: Run tests on Node.js v14 #13210

merged 4 commits into from
Apr 23, 2020

Conversation

fisker
Copy link
Contributor
@fisker fisker commented Apr 22, 2020 •
edited
Loading

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

Run tests on Node.js v14

What changes did you make? (Give an overview)

Add Node.js v14, remove v13 , v12 on windows and macOS

Is there anything you'd like reviewers to focus on?

Not much

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Apr 22, 2020
nzakas
nzakas reviewed Apr 22, 2020
View reviewed changes
.github/workflows/ci.yml Outdated
exclude:
- os: windows-latest
node: "10.12.0"
- os: windows-latest
node: 10.x
- os: windows-latest
node: 13.x
node: 12.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can probably just remove this entry as we still want to test 12.x and this would exclude it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already test 12.x on linux, don't you think 10 + 14 is enough for macOS and windows?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, sorry I though 10.x is tested, seems we only test 12 on windows before, make sense, I'll add 12.x

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have intended the job to test ESLint with multiple versions of Node.js on Linux and with the LTS Node.js on multiple platforms. Because of avoiding combination explosion. I should write a comment about my intention, sorry.

Therefore, I think we should test on Windows/Mac with the LTS 12.x.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@kaicataldo kaicataldo mentioned this pull request Apr 23, 2020
Closed
2 tasks
@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing build This change relates to ESLint's build process and removed triage An ESLint team member will look at this issue soon labels Apr 23, 2020
@kaicataldo
Copy link
Member

Thank you for contributing to ESLint!

@kaicataldo kaicataldo merged commit 6b7030b into eslint:master Apr 23, 2020
@fisker fisker deleted the test-nodejs-14 branch April 23, 2020 23:21
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Oct 21, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Oct 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nzakas nzakas nzakas left review comments

@kaicataldo kaicataldo kaicataldo approved these changes

@mysticatea mysticatea mysticatea approved these changes

@btmills btmills btmills approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion build This change relates to ESLint's build process chore This change is not user-facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fisker @kaicataldo @nzakas @btmills @mysticatea