8000 reconsider whether nicklen needs to be enforced against the casefolded nick · Issue #2238 · ergochat/ergo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
reconsider whether nicklen needs to be enforced against the casefolded nick #2238
New issue
New issue
Open
Open
reconsider whether nicklen needs to be enforced against the casefolded nick#2238
Labels
i18nneeds-investigation
Milestone
 
selected
@slingamn

Description

@slingamn
slingamn
opened on Mar 30, 2025

ergo/irc/client_lookup_set.go

Lines 154 to 156 in f5bb5af

if len(newNick) > config.Limits.NickLen || len(newCfNick) > config.Limits.NickLen {
return "", errNicknameInvalid, false
}

We enforce the nick length limit against both the original and the casefolded nickname. Under PRECIS, some case-normalized nicknames are longer than the original nickname (the report we got was about イザベラ).

What is nicklen really intended to protect? Can we just remove the second half of this check?

Metadata

Metadata

Assignees

No one assigned

    Labels

    i18nneeds-investigation

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      0