8000 Img alt should have the full name by alifhaider · Pull Request #1009 · epicweb-dev/epic-stack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Img alt should have the full name #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

Img alt should have the full name #1009

merged 1 commit into from
May 13, 2025

Conversation

alifhaider
Copy link
Contributor

For e2e testing, it uses name ?? username

epic-stack/tests/e2e/settings-profile.test.ts

Lines 59 to 61 in b92c19a

const beforeSrc = await page
.getByRole('img', { name: user.name ?? user.username })
.getAttribute('src')

@alifhaider
Img alt should have the full name
ed81bdb 
For e2e testing, it uses `name ?? username`
kentcdodds
kentcdodds approved these changes May 13, 2025
View reviewed changes
Copy link
Member
@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit b584f0c into epicweb-dev:main May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alifhaider @kentcdodds
0