8000 change self_attn_type · Issue #21 · eole-nlp/eole · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

change self_attn_type #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vince62s opened this issue Jun 11, 2024 · 0 comments · Fixed by #25
Closed

change self_attn_type #21

vince62s opened this issue Jun 11, 2024 · 0 comments · Fixed by #25
Labels
enhancement New feature or request

Comments

@vince62s
Copy link
Contributor

I think it should be self_attn_backend, and should not be a model setting but a training setting on top of an inference setting

values should be: "flash2", "pytorch"
"pytorch" would include the sdpa_kernels used here: https://github.com/eole-nlp/eole/blob/main/eole/modules/multi_headed_attn.py#L637

we could test if flash2 is installed at training/inference start and adjust backend if necessary.

thus we could remove the flash2 setting from the MHA (redundant with self_attn_backend)
@francoishernandez francoishernandez added the enhancement New feature or request label Jun 12, 2024
@francoishernandez francoishernandez linked a pull request Jun 13, 2024 that will close this issue
review flash/sdpa arg #25
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

review flash/sdpa arg vince62s/eole
2 participants
@francoishernandez @vince62s
0