Potentially breaking changed in URL building #3559
Unanswered
jlcsilva
asked this question in
Potential Issue
Replies: 1 comment 2 replies
-
|
This looks like a duplicate of #3433 |
Beta Was this translation helpful? Give feedback.
2 replies
-
|
Oh sorry. I tried to look it up under the api breaking changes, but only open ones. Since the original has been closed, feel free to close this too. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks @jlcsilva also an issue on our side, specifically that https://github.com/encode/httpx/blob/master/CHANGELOG.md doesn't mention this change. If someone's motivated to add a clean concise entry that'd be welcome. |
Beta Was this translation helpful? Give feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
This PR introduced potentially breaking changes in the way URLs are built.
Previously, the input
url=http://example.com?param=testandparams={}would result in a finalself.url=http://example.com?param=test.Now, the same input results in
self.url=http://example.com, completely removing the query parameters.Beta Was this translation helpful? Give feedback.
All reactions