From f09a96ec4ac21e12c7c4233f4afa0f16ebf3920f Mon Sep 17 00:00:00 2001 From: Steven <25894545+teamchong@users.noreply.github.com> Date: Thu, 20 Mar 2025 00:23:01 -0400 Subject: [PATCH 1/2] fix: properly escape PowerShell parameters in Azure trust signing --- .../app-builder-lib/src/codeSign/windowsSignAzureManager.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/app-builder-lib/src/codeSign/windowsSignAzureManager.ts b/packages/app-builder-lib/src/codeSign/windowsSignAzureManager.ts index 7f9ff19abd0..dbe082c75f5 100644 --- a/packages/app-builder-lib/src/codeSign/windowsSignAzureManager.ts +++ b/packages/app-builder-lib/src/codeSign/windowsSignAzureManager.ts @@ -130,7 +130,8 @@ export class WindowsSignAzureManager implements SignManager { const paramsString = Object.entries(params) .filter(([_, value]) => value != null) .reduce((res, [field, value]) => { - return [...res, `-${field}`, value] + const escapedValue = String(value).replace(/'/g, "''") + return [...res, `-${field}`, `'${escapedValue}'`] }, [] as string[]) .join(" ") await vm.exec(ps, ["-NoProfile", "-NonInteractive", "-Command", `Invoke-TrustedSigning ${paramsString}`]) From 5712289cb07faaa821fb4c8d6f69b218f7232ad1 Mon Sep 17 00:00:00 2001 From: Mike Maietta Date: Wed, 19 Mar 2025 22:08:57 -0700 Subject: [PATCH 2/2] Create friendly-drinks-allow.md --- .changeset/friendly-drinks-allow.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/friendly-drinks-allow.md diff --git a/.changeset/friendly-drinks-allow.md b/.changeset/friendly-drinks-allow.md new file mode 100644 index 00000000000..a09cacf0f8e --- /dev/null +++ b/.changeset/friendly-drinks-allow.md @@ -0,0 +1,5 @@ +--- +"app-builder-lib": patch +--- + +Fix: Azure trust signing fails with spaces in parameters