8000 Invalid `OsxNotarizeOptions` type · Issue #1162 · electron/packager · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Invalid OsxNotarizeOptions type #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
ffflorian opened this issue Jun 29, 2020 · 3 comments · Fixed by #1167
Closed
3 tasks done

Invalid OsxNotarizeOptions type #1162

ffflorian opened this issue Jun 29, 2020 · 3 comments · Fixed by #1167
Labels
bug 🐛 build-target:mac 🍎 Bundling an Electron app specifically for macOS help wanted Needs a contributor from the community

Comments

@ffflorian
Copy link
ffflorian commented Jun 29, 2020 •
edited
Loading

Preflight Checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details

  • Electron Packager Version:
    • 15.0.0
  • Electron Version:
    • none
  • Operating System:
    • Debian 10
  • Last Known Working Electron Packager version::
    • @types/electron-packager 14.0.0

Expected Behavior

The type defintions for electronPackager.Options.osxNotarize allows the options documented in electron-notarize.

Actual Behavior

The type defintions for electronPackager.Options.osxNotarize only allow ascProvider:

image

To Reproduce

Sample code:

import * as electronPackager from "electron-packager";

const packagerConfig: electronPackager.Options = {
  dir: "test",
  osxNotarize: {
    appleId: "id",
    appleIdPassword: "password",
  },
};

Additional Information

TypeScript's Omit<> is used in index.d.ts and this is probably the issue:

type OsxNotarizeOptions = Omit<NotarizeOptions, 'appBundleId' | 'appPath'>;
@welcome
Copy link
welcome bot commented Jun 29, 2020

👋 Thanks for opening your first issue here! If you have a question about using Electron Packager, read the support docs. If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. Development and issue triage is community-driven, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@malept
Copy link
Member
malept commented Jun 29, 2020

Do you mind making a pull request to fix this?

@malept malept added help wanted Needs a contributor from the community build-target:mac 🍎 Bundling an Electron app specifically for macOS labels Jul 1, 2020
@ffflorian
Copy link
Author

Do you mind making a pull request to fix this?

Unfortunately I also don't know how to fix this. I tried a few things but they didn't work 😕

@malept malept mentioned this issue Jul 10, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 build-target:mac 🍎 Bundling an Electron app specifically for macOS help wanted Needs a contributor from the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(typescript): ensure OsxNotarizeOptions definition contains credentials electron/packager
2 participants
@malept @ffflorian
0