8000 detecting non-renderable URLs · Issue #1253 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
detecting non-renderable URLs #1253
Closed
@max-mapper

Description

@max-mapper

If I load a non-renderable URL, such as a .zip or something that would prompt a 'download as' prompt in a browser, atom-shell renders a blank page.

The problem I'm running in to is I am not sure how to detect that something is non-renderable.

Here's a gif of what I mean:

atom-shell-load-events

Here's the source code of the test program: https://gist.github.com/maxogden/891f9f69be667e11fa5e

I've noticed that the did-stop-loading event fires before did-finish-load, and in the did-stop-loading callback I get false from WebContents.isLoading()

My problem is that I have no way of knowing if did-stop-loading (correction: I mean did-finish-load) will ever fire, as it never fires for non-renderable content. But there doesn't seem to be a way to know if the content is non-renderable through the API.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0