From bdf7b2a42a64d06504d021a0a20aea4191c83b7c Mon Sep 17 00:00:00 2001 From: Jonathan Hogg Date: Thu, 1 Aug 2024 19:28:09 +0100 Subject: [PATCH 1/2] Don't attempt to build C bindings for Python package --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index 16bf1472f..14d6143e5 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -44,7 +44,7 @@ sdist.exclude = [ "bindings/python/third_party/nanobind/docs/", ] wheel.packages = ["manifold3d"] -cmake.args = ["-DMANIFOLD_PYBIND=ON", "-DMANIFOLD_PAR=TBB", "-DMANIFOLD_TEST=OFF", "-DBUILD_SHARED_LIBS=OFF"] +cmake.args = ["-DMANIFOLD_PYBIND=ON", "-DMANIFOLD_CBIND=OFF", "-DMANIFOLD_PAR=TBB", "-DMANIFOLD_TEST=OFF", "-DBUILD_SHARED_LIBS=OFF"] install.components = ["bindings"] [tool.cibuildwheel] From 653cc2598a72c9ed483dbd1bfbf8d04a49124dc9 Mon Sep 17 00:00:00 2001 From: Jonathan Hogg Date: Sat, 3 Aug 2024 08:40:45 +0100 Subject: [PATCH 2/2] Add workflow stage to do a test build of the SDist --- .github/workflows/build_wheels.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build_wheels.yml b/.github/workflows/build_wheels.yml index 88dfcb44b..4b97e5f91 100644 --- a/.github/workflows/build_wheels.yml +++ b/.github/workflows/build_wheels.yml @@ -1,6 +1,6 @@ name: build_wheels -on: +on: release: types: [published] workflow_dispatch: @@ -35,6 +35,8 @@ jobs: submodules: recursive - name: Build SDist run: pipx run build --sdist + - name: Confirm SDist can be built + run: pip wheel dist/*.tar.gz - uses: actions/upload-artifact@v4 with: name: python-sdist