8000 Break up `Cluster::clusterShape` into named fields · Issue #85 · eic/EDM4eic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Break up Cluster::clusterShape into named fields #85
New issue
New issue
Open
Open
Break up Cluster::clusterShape into named fields#85
@veprbl

Description

@veprbl
veprbl
opened on Jul 7, 2024

The clusterShape vector member had become a dumping ground for additional values that bypass EDM review procedure

EDM4eic/edm4eic.yaml

Line 292 in f21b388

- float shapeParameters // Should be set in metadata, for now it's a list of -- radius [mm], dispersion [mm], 2 entries for theta-phi widths [rad], 3 entries for x-y-z widths [mm].

In addition to that, accessing values by index is confusing to our users. We should migrate away from this approach.

See also eic/EICrecon#1511

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      0