8000 ⚠️Error: Please support `.tar.gz` binary asset for Windows · Issue #415 · editorconfig-checker/editorconfig-checker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
⚠️Error: Please support .tar.gz binary asset for Windows #415
Closed
@lumirlumir

Description

@lumirlumir

@mstruebing @klaernie @theoludwig

Hello,

This is a follow-up issue to #409.

In version v3.0.3, .tar.gz files for Windows were supported, as shown below:

image

However, in v3.1.0 and v3.1.1, .tar.gz files for Windows are no longer supported. Instead, only .zip files are available, as seen in the screenshot below:

image


In editorconfig-checker.javascript, the code still tries to locate .tar.gz files:

https://github.com/editorconfig-checker/editorconfig-checker.javascript/blob/c78ecb0c123a71888e1165d17bfc22daf40ceb0d/src/release.ts#L18

  const matchedAsset = release.data.assets.find(({ name }) => {
    return name.startsWith(releasePrefix) && name.endsWith(".tar.gz")
  })

As a result, this causes an error like the one below:

image


I believe there are two possible solutions:

  1. Add .tar.gz support back to the assets.
  2. Update editorconfig-checker.javascript to support resolving .zip files.

If the second solution is acceptable, I would be happy to create a pull request for it. Please let me know once a decision has been made.

4598

Metadata

Metadata

Assignees

No one assigned

    Labels

    buga bug which occuredhelp wantedwindowsbugs specific to windows

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0