[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to use external "moment" package #517

Closed
nicoladefranceschi opened this issue Mar 15, 2018 · 3 comments
Closed

Ability to use external "moment" package #517

nicoladefranceschi opened this issue Mar 15, 2018 · 3 comments

Comments

@nicoladefranceschi
Copy link
Contributor
nicoladefranceschi commented Mar 15, 2018 •
edited
Loading

Hi,
I'm using this package in my project and it's great!
However when I pack my project using webpack, I notice that the bundle contains two moment libraries, one that I use in my project, and the other used in this library.
This means that the size on my bundle increases significantly (around 460kb).

In my project I'm using "moment": "^2.20.1"
In exceljs it's instead "moment": "2.19.3"

I would suggest to change the dependence's version, but it would be even better to be able to initialized the library passing my own version of moment.

What do you think?

Thanks!
@guyonroche
Copy link
Collaborator

@nicoladefranceschi I think it would be easier for now to loosen exceljs's dependency requirements (to say >=2.19.3). This will satisfy your need as then npm will align the two without complicating anything.

@nicoladefranceschi
Copy link
Contributor Author

Ok thanks!
I created a pull request:

#524

@guyonroche
Copy link
Collaborator

Published in v1.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicoladefranceschi @guyonroche