8000 Add native implementation of BLAKE2bf precompile by chfast · Pull Request #857 · ipsilon/evmone · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add native implementation of BLAKE2bf precompile #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 11, 2024
Merged

Add native implementation of BLAKE2bf precompile #857

merged 3 commits into from
Apr 11, 2024

Conversation

chfast
Copy link
Member
@chfast chfast commented Apr 5, 2024
  • Adds the implementation of the BLAKE2b compress function F following the RFC 7693.
  • Implements EIP-152 "BLAKE2 compression function F precompile" by exposing the evmone::crypto::blake2b_compress().
  • Do not cache this precompile.

@chfast chfast added the precompiles Related to EVM precompiles label Apr 5, 2024< 8000 /a>
@codecov Codecov
Copy link
codecov bot commented Apr 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.05263% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 98.10%. Comparing base (cd1f3f6) to head (b2af042).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #857      +/-   ##
==========================================
- Coverage   98.13%   98.10%   -0.03%     
==========================================
  Files         125      127       +2     
  Lines       13095    13171      +76     
==========================================
+ Hits        12851    12922      +71     
- Misses        244      249       +5
Flag Coverage Δ
statetests 63.38% <100.00%> (+0.47%) ⬆️
statetests-silkpre 22.13% <62.31%> (+0.22%) ⬆️
unittests 96.69% <77.63%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/evmone_precompiles/blake2b.cpp 100.00% <100.00%> (ø)
test/state/precompiles_cache.cpp 58.82% <ø> (ø)
test/unittests/precompiles_blake2b_test.cpp 100.00% <100.00%> (ø)
test/state/precompiles.cpp 89.71% <82.35%> (-0.80%) ⬇️

... and 1 file with indirect coverage changes

@chfast chfast changed the title Add the BLAKE2bf precompile Add native implementation of BLAKE2bf precompile Apr 5, 2024
@chfast chfast requested a review from rodiazet April 5, 2024 14:39
@chfast chfast force-pushed the precompiles/blake2bf branch from 33af85c to b7fb324 Compare April 5, 2024 15:25
@chfast chfast force-pushed the precompiles/ripemd160 branch from 5187061 to f82140a Compare April 11, 2024 08:12
Base automatically changed from precompiles/ripemd160 to master April 11, 2024 08:59
chfast added 3 commits April 11, 2024 12:23
@chfast
crypto: Implement BLAKE2b compress function F
404c6f3 
Adds the implementation of the BLAKE2b compress function F following
the [RFC 7693](https://datatracker.ietf.org/doc/html/rfc7693).
@chfast
precompiles: Add the BLAKE2bf precompile
d46e3b9 
Implement [EIP-152](https://eips.ethereum.org/EIPS/eip-152)
"BLAKE2 compression function `F` precompile" by exposing
the `evmone::crypto::blake2b_compress()`.
@chfast
precompiles: Do not cache the BLAKE2bf precompile
b2af042
@chfast chfast force-pushed the precompiles/blake2bf branch from 308c86a to b2af042 Compare April 11, 2024 10:25
@chfast chfast requested a review from battlmonstr April 11, 2024 10:51
battlmonstr
battlmonstr approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor
@battlmonstr battlmonstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@battlmonstr battlmonstr merged commit 0b648e3 into master Apr 11, 2024
@battlmonstr battlmonstr deleted the precompiles/blake2bf branch April 11, 2024 12:45
@chfast
Copy link
Member Author
chfast commented Apr 11, 2024

Thanks for the review but don't merge next time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@battlmonstr battlmonstr battlmonstr approved these changes

@rodiazet rodiazet Awaiting requested review from rodiazet

Assignees
No one assigned
Labels
precompiles Related to EVM precompiles
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chfast @battlmonstr
0