8000 [Feature]: Check the VPC validity on server startup · Issue #1157 · dstackai/dstack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Feature]: Check the VPC validity on server startup #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
peterschmidt85 opened this issue Apr 22, 2024 · 1 comment · Fixed by #1170
Closed

[Feature]: Check the VPC validity on server startup #1157

peterschmidt85 opened this issue Apr 22, 2024 · 1 comment · Fixed by #1170
Assignees
@r4victor
Labels
feature ux

Comments

@peterschmidt85
Copy link
Contributor

Problem

Currently, if I set up an AWS backend and start the server, I don't see if I configured the VPC correctly. Because the VPC is configured by the admin, the admin should see if it was configured correctly.

Solution

  • The server on startup should check if the specified VPCs are available in the configured regions and are public.
  • If VPC is not configured, the server should check that the default VPC exists in the configured regions and is public.

Workaround

No response

Would you like to help us implement this feature by sending a PR?

Yes
@r4victor
Copy link
Collaborator

Note that vpc should be checked when launching instance anyway since the vpc configuration may change after backend configuration.

Also, checking that VPCs in all regions have public subnets may take some time due to many network requests. The checks in different regions have to be done in parallel.

@r4victor r4victor self-assigned this Apr 25, 2024
@r4victor r4victor mentioned this issue Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r4victor r4victor

Labels
feature ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow to configure AWS vpc_ids dstackai/dstack
2 participants
@r4victor @peterschmidt85
0