8000 [Feature]: Allow to configure VPCs via their IDs rather than name · Issue #1156 · dstackai/dstack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Feature]: Allow to configure VPCs via their IDs rather than name #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
peterschmidt85 opened this issue Apr 22, 2024 · 1 comment 8000 Fixed by #1170
Closed

[Feature]: Allow to configure VPCs via their IDs rather than name #1156

peterschmidt85 opened this issue Apr 22, 2024 · 1 comment · Fixed by #1170
Assignees
@r4victor
Labels
feature major ux

Comments

@peterschmidt85
Copy link
Contributor

Problem

Often VPCs have no name configured and can be only referenced by their ID. Also, in most cases, ML engineers don't have permission to change the names of VPCs.

Solution

Allow to configure VPCs by their IDs for every region.

Workaround

No response

Would you like to help us implement this feature by sending a PR?

No
@r4victor
Copy link
Collaborator

I can suggest the following configuration format:

- type: aws
  ...
  vpc_ids:
    us-east-1: vpc-0a2b3c4d5e6f7g8h
    us-east-2: vpc-9i8h7g6f5e4d3c2b
    us-west-1: vpc-4d3c2b1a0f9e8d7
    us-west-2: vpc-6f5e4d3c2b1a09i
    ap-southeast-1: vpc-8h7g6f5e4d3c2b1
    ca-central-1: vpc-3c2b1a09i8h7g6f
    eu-central-1: vpc-5e4d3c2b1a09i8h
    eu-west-1: vpc-2b1a09i8h7g6f5e4
    eu-west-2: vpc-1a09i8h7g6f5e4d3
    eu-west-3: vpc-9i8h7g6f5e4d3c2b
    eu-north-1: vpc-7g6f5e4d3c2b1a09

Users will be able to configure either vpc_name or vpc_ids. vpc_ids have to be specified for all configured regions.

@r4victor r4victor self-assigned this Apr 25, 2024
@r4victor r4victor mentioned this issue Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r4victor r4victor

Labels
feature major ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow to configure AWS vpc_ids dstackai/dstack
2 participants
@r4victor @peterschmidt85
0