8000 Do not require backends to return IP address in `run_job` or `create_instance` · Issue #1148 · dstackai/dstack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Do not require backends to return IP address in run_job or create_instance #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
r4victor opened this issue Apr 17, 2024 · 0 comments · Fixed by #1149
Closed

Do not require backends to return IP address in run_job or create_instance #1148

r4victor opened this issue Apr 17, 2024 · 0 comments · Fixed by #1149
Assignees
@r4victor
Labels
internals ux

Comments

@r4victor
Copy link
Collaborator

Currently, backends must return hostname in LaunchedInstanceInfo so that the job processing task can connect to the instance. It takes time to get the ip address for some providers. This leads to backends blocking other jobs when waiting for ip in run_job/create_instance and issues like #1145

The solution is to allow backends to not return hostname/port/etc and implement a method that would get the instance status by instance_id. This method would fill hostname/port when they become available. The job processing task would call this method until hostname/port are filled or timeout occurs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r4victor r4victor

Labels
internals ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor backends to wait for instance IP address outside run_job/create_instance dstackai/dstack
1 participant
@r4victor
0