8000 Documentation is confusing for the bucket parameter · Issue #31 · drone-plugins/drone-s3-sync · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Documentation is confusing for the bucket parameter #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mprasil opened this issue Sep 2, 2017 · 5 comments
Open

Documentation is confusing for the bucket parameter #31

mprasil opened this issue Sep 2, 2017 · 5 comments

Comments

@mprasil
Copy link
mprasil commented Sep 2, 2017 •
edited
Loading

The documentation shows bucket parameter provided in two different formats (actually twice for each example):

bucket: my-bucket-name
...
bucket: my-bucket.s3-website-us-east-1.amazonaws.com

Which format is the correct one?

The link to the documentation: http://plugins.drone.io/drone-plugins/drone-s3-sync/
@bradrydzewski
Copy link
Member

Which docs are you looking at?

@bradrydzewski
Copy link
Member

On my phone so can't test, but maybe consider testing both and then send a patch to the docs for whichever is the correct config

@tboerger
Copy link
Contributor
tboerger commented Sep 2, 2017

This is a mistake from my side, I have not checked it but I think both formats should work, more common is the first one

@mprasil
85A9
Copy link
Author
mprasil commented Sep 2, 2017

I think the first one works, (at least for couple of my configurations it does) though I have some failing one at the moment as well and not sure why is it failing yet.

@FERNman
Copy link
FERNman commented Sep 17, 2020

After looking through the source code, I think the second bucket entry in the documentation should actually be called endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tboerger @bradrydzewski @mprasil @FERNman
0