8000 Insecure handling of repo encryption password · Issue #80 · drdo/redu · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Insecure handling of repo encryption password #80
Closed
@clonejo

Description

@clonejo

Assuming a scenario where the password is entered interactively on stdin.

  1. The password is passed to restic in an environment variable. This means it is readable to other processes by the same user (https://security.stackexchange.com/questions/14000/environment-variable-accessibility-in-linux/14009#14009, https://restic.readthedocs.io/en/stable/faq.html#how-can-i-specify-encryption-passwords-automatically)
  2. The password is logged to ~/.local/share/redu/logs/*.log, as part of the command line:
    15:03:35 [INFO] redu::restic: running "RESTIC_PASSWORD="secret password" "restic" "--repo" "sftp:some-host:some/path" "--json" " cat" "config"" (pid 29773)
    

In $PR you will find a fix by passing the password using stdin.

In addition, users should be informed.

Would it be a good idea to automatically remove/rewrite existing log files containing passwords?

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0