From b56bf21d283a01038c8e965e1b8cb330d96f68a7 Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Wed, 2 Apr 2025 18:29:44 -0400 Subject: [PATCH 1/3] [tests] Quarantine additional tests for issues open against them These tests have issues open for them, but tests aren't marked with QuarantinedTest attribute. --- .../AzureCosmosDBEmulatorFunctionalTests.cs | 1 + tests/Aspire.Hosting.MySql.Tests/MySqlFunctionalTests.cs | 1 + tests/Aspire.Hosting.Tests/MSBuildTests.cs | 3 ++- tests/Aspire.Hosting.Tests/OperationModesTests.cs | 1 + 4 files changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/Aspire.Hosting.Azure.Tests/AzureCosmosDBEmulatorFunctionalTests.cs b/tests/Aspire.Hosting.Azure.Tests/AzureCosmosDBEmulatorFunctionalTests.cs index b8b1634c27f..cac478d0c5b 100644 --- a/tests/Aspire.Hosting.Azure.Tests/AzureCosmosDBEmulatorFunctionalTests.cs +++ b/tests/Aspire.Hosting.Azure.Tests/AzureCosmosDBEmulatorFunctionalTests.cs @@ -22,6 +22,7 @@ public class AzureCosmosDBEmulatorFunctionalTests(ITestOutputHelper testOutputHe // [InlineData(true)] // "Using CosmosDB emulator in integration tests leads to flaky tests - https://github.com/dotnet/aspire/issues/5820" [InlineData(false)] [RequiresDocker] + [QuarantinedTest("//github.com/dotnet/aspire/issues/7345")] public async Task VerifyWaitForOnCosmosDBEmulatorBlocksDependentResources(bool usePreview) { // Cosmos can be pretty slow to spin up, lets give it plenty of time. diff --git a/tests/Aspire.Hosting.MySql.Tests/MySqlFunctionalTests.cs b/tests/Aspire.Hosting.MySql.Tests/MySqlFunctionalTests.cs index b8315809e5a..ea0165cc0e2 100644 --- a/tests/Aspire.Hosting.MySql.Tests/MySqlFunctionalTests.cs +++ b/tests/Aspire.Hosting.MySql.Tests/MySqlFunctionalTests.cs @@ -377,6 +377,7 @@ await pipeline.ExecuteAsync(async token => [Fact] [RequiresDocker] + [QuarantinedTest("https://github.com/dotnet/aspire/issues/7340")] public async Task VerifyEfMySql() { var cts = new CancellationTokenSource(TimeSpan.FromMinutes(5)); diff --git a/tests/Aspire.Hosting.Tests/MSBuildTests.cs b/tests/Aspire.Hosting.Tests/MSBuildTests.cs index f4c5768ab43..a611955ea99 100644 --- a/tests/Aspire.Hosting.Tests/MSBuildTests.cs +++ b/tests/Aspire.Hosting.Tests/MSBuildTests.cs @@ -3,6 +3,7 @@ using System.Diagnostics; using System.Text; +using Aspire.TestUtilities; using Xunit; namespace Aspire.Hosting.Tests; @@ -13,7 +14,7 @@ public class MSBuildTests /// Tests that when an AppHost has a ProjectReference to a library project, a warning is emitted. /// [Fact] - [ActiveIssue("https://github.com/dotnet/aspire/issues/8467")] + [QuarantinedTest("https://github.com/dotnet/aspire/issues/8467")] public void EnsureWarningsAreEmittedWhenProjectReferencingLibraries() { var repoRoot = MSBuildUtils.GetRepoRoot(); diff --git a/tests/Aspire.Hosting.Tests/OperationModesTests.cs b/tests/Aspire.Hosting.Tests/OperationModesTests.cs index 5485846f872..36dd5c9e81e 100644 --- a/tests/Aspire.Hosting.Tests/OperationModesTests.cs +++ b/tests/Aspire.Hosting.Tests/OperationModesTests.cs @@ -14,6 +14,7 @@ namespace Aspire.Hosting.Tests; public class OperationModesTests(ITestOutputHelper outputHelper) { [Fact] + [QuarantinedTest("https://github.com/dotnet/aspire/issues/8400")] public async Task VerifyBackwardsCompatableRunModeInvocation() { // The purpose of this test is to verify that the apphost executable will continue From 5807cc4950a807426ecab984d3cb36abd0f86ddc Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Thu, 3 Apr 2025 00:02:01 -0400 Subject: [PATCH 2/3] Quarantine Aspire.Hosting.Tests.WithHttpCommandTests.WithHttpCommand_ResultsInExpectedResultForHttpMethod --- tests/Aspire.Hosting.Tests/WithHttpCommandTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Aspire.Hosting.Tests/WithHttpCommandTests.cs b/tests/Aspire.Hosting.Tests/WithHttpCommandTests.cs index fa5a059f9bb..d11184aedf4 100644 --- a/tests/Aspire.Hosting.Tests/WithHttpCommandTests.cs +++ b/tests/Aspire.Hosting.Tests/WithHttpCommandTests.cs @@ -161,6 +161,7 @@ public async Task WithHttpCommand_ResultsInExpectedResultForStatusCode(int statu [InlineData("get", true)] [InlineData("post", false)] [Theory] + [QuarantinedTest("https://github.com/dotnet/aspire/issues/8514")] public async Task WithHttpCommand_ResultsInExpectedResultForHttpMethod(string? httpMethod, bool expectSuccess) { // Arrange From c775a14c188f0bfcb445af0bdbbea8dfced30e3c Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Thu, 3 Apr 2025 00:09:53 -0400 Subject: [PATCH 3/3] Update tests/Aspire.Hosting.Azure.Tests/AzureCosmosDBEmulatorFunctionalTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- .../AzureCosmosDBEmulatorFunctionalTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Aspire.Hosting.Azure.Tests/AzureCosmosDBEmulatorFunctionalTests.cs b/tests/Aspire.Hosting.Azure.Tests/AzureCosmosDBEmulatorFunctionalTests.cs index cac478d0c5b..5ac47cbf3fa 100644 --- a/tests/Aspire.Hosting.Azure.Tests/AzureCosmosDBEmulatorFunctionalTests.cs +++ b/tests/Aspire.Hosting.Azure.Tests/AzureCosmosDBEmulatorFunctionalTests.cs @@ -22,7 +22,7 @@ public class AzureCosmosDBEmulatorFunctionalTests(ITestOutputHelper testOutputHe // [InlineData(true)] // "Using CosmosDB emulator in integration tests leads to flaky tests - https://github.com/dotnet/aspire/issues/5820" [InlineData(false)] [RequiresDocker] - [QuarantinedTest("//github.com/dotnet/aspire/issues/7345")] + [QuarantinedTest("https://github.com/dotnet/aspire/issues/7345")] public async Task VerifyWaitForOnCosmosDBEmulatorBlocksDependentResources(bool usePreview) { // Cosmos can be pretty slow to spin up, lets give it plenty of time.