8000 Add ability to manipulate config passed to subsystems beyond passing a set of refs · Issue #33 · donut-party/system · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add ability to manipulate config passed to subsystems beyond passing a set of refs #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cap10morgan opened this issue Apr 16, 2024 · 1 comment

Comments

@cap10morgan
Copy link
Contributor

I have a subsystem that needs its config in a different format (in this case a different key name and turning a port number into a full URL), but it seems all you can do w/ subsystems is pass a set of refs. Is there a way to manipulate the config before it gets passed to the subsystem's start fns?

I don't want to modify the subsystem to accept the parent's config ref as-is b/c I'm just using it as a subsystem in an integration test system where I pull in this other system as a library. Treating it as a subsystem there seemed like a good way to couple its lifecycle to the overall test system I'm starting. But outside of integration testing, it's an entirely different component that is run on its own. So I don't want these two system's configs to be tightly coupled by this test integration.

Let me know if subsystems aren't the best approach here, or if there is already a way to do this config manipulation that I'm not seeing.

Thanks!

@flyingmachine
Copy link
Contributor

hey hey! It's taken me a while to get to this, sorry about that. Would it be possible to share an example if this is still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
0