-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug, critical: PROPFIND requires for Depth header #123
Comments
I didn't get why the webdav-js makes a HEAD requests for a folder. This looks like a bug for me. |
Ok, I get it. The HEAD against a directory will return 403 if there is no any HTML e.g. not index.html or directory listing enabled. Exactly the same behavior from IIS. IIS With directory browsing enabled: IISWith directory browsing enabled or index.html in the /folder/: Same for the Lighttpd. Looks like it was made compatible with IIS because it should be 404 instead. Looks like the issue never occurred before because I had a directory listing previously. But I just had a plain index as a fallback. Instead I always opened the root folder that had the index.html with the webdav-js an then opened a needed subfolder. The webdav-js is usually configured with |
This is not a bug in lighttpd. The RFC clearly states:
In https://redmine.lighttpd.net/boards/2/topics/10081 lighttpd choose not to reject @stokito please do not be sloppy. Also, please do not reference lighttpd and IIS together. lighttpd does not care one whit about IIS. |
@gstrauss I saw the 403 error and googled it and found the ticket but it's about PROPFIND and not about the HEAD. |
@stokito wrote
I repeat:
9.4. GET, HEAD for Collections @stokito you continue to demonstrate that you have no idea what you are talking about, and that you should be ignored. If that is not your intention, then please read the RFCs before jumping to the conclusion that there is a bug because you did not understand something. |
thank you. the spec also says:
So that's not a bug in the lighttpd |
That is a backhanded way of saying that you were wrong -- and wrong multiple times because you had not read the spec. I think a more proper statement is "lighttpd strives to be compliant with the WebDAV specification". I already linked to RFC 4918 section 9.1 above. Here it is again with a larger quote for those who do not read carefully: 9.1. PROPFIND Method
lighttpd can be configured to allow |
Thank you, once I'll have more time I'll read the spec. This is something that should be described in a spec (I hope it is). Because there may be some corner cases like what if the folder has too many files (e.g. rotated logs dir) and the server just can't finish the scanning. Meanwhile the Golang's net/webdav package behaves differently https://github.com/golang/net/blob/master/webdav/webdav.go#L527 |
The Lighttpd 1.4.61 now blocks PROPFIND without the
Depth: 0
orDepth: 1
. So when I trying to click on a folder I get the error:HEAD https://192.168.1.1/dav/photos/ net::ERR_ABORTED 403
Line HTTP.ts:45
Please add the
Depth: 1
for requests.See https://redmine.lighttpd.net/boards/2/topics/10081 for details
The text was updated successfully, but these errors were encountered: