8000 Saftey Feature Request · Issue #66 · dokutan/mouse_m908 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Saftey Feature Request #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
8000
BloodBlight opened this issue Jan 31, 2024 · 5 comments
Open

Saftey Feature Request #66

BloodBlight opened this issue Jan 31, 2024 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@BloodBlight
Copy link
BloodBlight commented Jan 31, 2024 •
edited
Loading

I was a dummy and fat fingered a command and sent the "example_m908.ini" to my M612.

This ended with a mouse that would not move left or right. Ops!

So, I tried re-sending the "generic" example, no help, have a second mouse, captured its config and sent it, no good.

So, found a Windowz box and fixed it there.

Cool.

But on to the feature request. Add a list of "known good" USB IDs and/or the ID that the configuration was captured from. Then if the devices ID isn't in that list, prompt the user with a warning before proceeding.
@dokutan dokutan added enhancement New feature or request good first issue Good for newcomers labels Jan 31, 2024
@dokutan
Copy link
Owner
dokutan commented Jan 31, 2024

I understand how this can be a problem in some cases, but would think that this problem can be avoided by keeping the personal config in an appropriate location (i.e. not in the examples directory). I suppose a config parameter could be added to specify the backend that the config is intended for (and write it when reading the config), then ask the user if this does not match the real backend without breaking every existing config.

As i currently don't have a lot of time to spend on this project, i'm not going to implement this for now, but would merge a pull request if it keeps backwards compatibility with existing configs.

@BloodBlight
Copy link
Author

Understood, I haven't coded c++ in like 20 years so... :)

Want me to leave it open or close it?

@dokutan
Copy link
Owner
dokutan commented Jan 31, 2024

Feel free to leave it open, i might implement this when i have more time, or someone else gives it a try.

@markhan101
Copy link

I would like to work on this issue.

I was thinking of maybe just adding a model header like [model=m908] and extracting the 908 and comparing it in the main loop itself or maybe adding a [metadata] header and having key value of model = m908 accessed by metadata.model maybe

@dokutan
Copy link
Owner
dokutan commented May 9, 2025

I think a new section like [options] would make sense that can replace/override some command line arguments (model, kernel driver, ...). Conflicting command line and config file options would need to be resolved in some meaningful way (at least with a warning).

I have no particular opionions about the implementation details, so i would leave it up to you to come up with something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BloodBlight @dokutan @markhan101
0