From 0042ffb4bc011e23a5aecb7cd1facee178ea28ee Mon Sep 17 00:00:00 2001 From: Sergei Morozov Date: Mon, 12 May 2025 15:06:56 -0700 Subject: [PATCH 1/3] Use fail-fast with shivammathur/setup-php@v2 --- .github/workflows/continuous-integration.yml | 2 ++ .github/workflows/nightly.yml | 2 ++ .github/workflows/phpunit-db2.yml | 1 + .github/workflows/phpunit-mariadb.yml | 2 ++ .github/workflows/phpunit-mysql.yml | 2 ++ .github/workflows/phpunit-oracle.yml | 2 ++ .github/workflows/phpunit-postgres.yml | 2 ++ .github/workflows/phpunit-sqlite.yml | 2 ++ .github/workflows/phpunit-sqlserver.yml | 2 ++ 9 files changed, 17 insertions(+) diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index a24743eee5..a01a73ab08 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -235,6 +235,8 @@ jobs: uses: "shivammathur/setup-php@v2" with: php-version: "${{ matrix.php-version }}" + env: + fail-fast: true - name: "Lower minimum stability" run: "composer config minimum-stability dev" diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index d4c900bb84..ea99e4f5aa 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -50,6 +50,8 @@ jobs: coverage: "pcov" ini-values: "zend.assertions=1" extensions: "${{ matrix.extension }}" + env: + fail-fast: true - name: "Install dependencies with Composer" uses: "ramsey/composer-install@v3" diff --git a/.github/workflows/phpunit-db2.yml b/.github/workflows/phpunit-db2.yml index 836ea254f5..649333c750 100644 --- a/.github/workflows/phpunit-db2.yml +++ b/.github/workflows/phpunit-db2.yml @@ -47,6 +47,7 @@ jobs: coverage: pcov ini-values: zend.assertions=1 env: + fail-fast: true IBM_DB2_CONFIGURE_OPTS: '--with-IBM_DB2=/tmp/clidriver' - name: Install dependencies with Composer diff --git a/.github/workflows/phpunit-mariadb.yml b/.github/workflows/phpunit-mariadb.yml index 2aab0602a6..0955390f2a 100644 --- a/.github/workflows/phpunit-mariadb.yml +++ b/.github/workflows/phpunit-mariadb.yml @@ -39,6 +39,8 @@ jobs: extensions: ${{ inputs.extension }} coverage: pcov ini-values: zend.assertions=1 + env: + fail-fast: true - name: Install dependencies with Composer uses: ramsey/composer-install@v3 diff --git a/.github/workflows/phpunit-mysql.yml b/.github/workflows/phpunit-mysql.yml index 11f7123a05..8e9b65784a 100644 --- a/.github/workflows/phpunit-mysql.yml +++ b/.github/workflows/phpunit-mysql.yml @@ -43,6 +43,8 @@ jobs: extensions: ${{ inputs.extension }} coverage: pcov ini-values: zend.assertions=1 + env: + fail-fast: true - name: Install dependencies with Composer uses: ramsey/composer-install@v3 diff --git a/.github/workflows/phpunit-oracle.yml b/.github/workflows/phpunit-oracle.yml index 3827bb22df..d3c0b1459e 100644 --- a/.github/workflows/phpunit-oracle.yml +++ b/.github/workflows/phpunit-oracle.yml @@ -41,6 +41,8 @@ jobs: extensions: ${{ inputs.extension }} coverage: pcov ini-values: zend.assertions=1 + env: + fail-fast: true - name: Install dependencies with Composer uses: ramsey/composer-install@v3 diff --git a/.github/workflows/phpunit-postgres.yml b/.github/workflows/phpunit-postgres.yml index 4173eb7483..53e74f37db 100644 --- a/.github/workflows/phpunit-postgres.yml +++ b/.github/workflows/phpunit-postgres.yml @@ -38,6 +38,8 @@ jobs: extensions: ${{ inputs.extension }} coverage: pcov ini-values: zend.assertions=1 + env: + fail-fast: true - name: Install dependencies with Composer uses: ramsey/composer-install@v3 diff --git a/.github/workflows/phpunit-sqlite.yml b/.github/workflows/phpunit-sqlite.yml index 543105d719..8e369145c3 100644 --- a/.github/workflows/phpunit-sqlite.yml +++ b/.github/workflows/phpunit-sqlite.yml @@ -30,6 +30,8 @@ jobs: php-version: ${{ inputs.php-version }} coverage: pcov ini-values: zend.assertions=1 + env: + fail-fast: true - name: Install dependencies with Composer uses: ramsey/composer-install@v3 diff --git a/.github/workflows/phpunit-sqlserver.yml b/.github/workflows/phpunit-sqlserver.yml index cb6f0b3104..f73d346989 100644 --- a/.github/workflows/phpunit-sqlserver.yml +++ b/.github/workflows/phpunit-sqlserver.yml @@ -41,6 +41,8 @@ jobs: coverage: pcov ini-values: zend.assertions=1 tools: pecl + env: + fail-fast: true - name: Install dependencies with Composer uses: ramsey/composer-install@v3 From 55f6edd640c747bd662256c4952e9b37fc14eba7 Mon Sep 17 00:00:00 2001 From: Sergei Morozov Date: Mon, 12 May 2025 15:07:29 -0700 Subject: [PATCH 2/3] Do not use fail-fast in nightly builds --- .github/workflows/nightly.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index ea99e4f5aa..aeae23ac68 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -4,9 +4,6 @@ on: schedule: - cron: "12 3 * * *" -env: - fail-fast: true - jobs: phpunit-mariadb-devel: name: "PHPUnit with MariaDB" From 511fc7e1936a0cb2d77d75d37a975159f19cd4fc Mon Sep 17 00:00:00 2001 From: Sergei Morozov Date: Fri, 16 May 2025 15:46:46 -0700 Subject: [PATCH 3/3] Fail on PHPUnit deprecations --- ci/appveyor/mssql.sql2017.pdo_sqlsrv.appveyor.xml | 2 ++ ci/appveyor/mssql.sql2017.sqlsrv.appveyor.xml | 2 ++ ci/github/phpunit/ibm_db2.xml | 2 ++ ci/github/phpunit/mysqli-tls.xml | 2 ++ ci/github/phpunit/mysqli.xml | 2 ++ ci/github/phpunit/oci8-21.xml | 2 ++ ci/github/phpunit/oci8.xml | 2 ++ ci/github/phpunit/pdo_mysql.xml | 2 ++ ci/github/phpunit/pdo_oci-21.xml | 2 ++ ci/github/phpunit/pdo_oci.xml | 2 ++ ci/github/phpunit/pdo_pgsql.xml | 2 ++ ci/github/phpunit/pdo_sqlite.xml | 2 ++ ci/github/phpunit/pdo_sqlsrv.xml | 2 ++ ci/github/phpunit/pgsql.xml | 2 ++ ci/github/phpunit/sqlite3.xml | 2 ++ ci/github/phpunit/sqlsrv.xml | 2 ++ phpunit.xml.dist | 2 ++ 17 files changed, 34 insertions(+) diff --git a/ci/appveyor/mssql.sql2017.pdo_sqlsrv.appveyor.xml b/ci/appveyor/mssql.sql2017.pdo_sqlsrv.appveyor.xml index fcc5dd087d..cfd468bf0b 100644 --- a/ci/appveyor/mssql.sql2017.pdo_sqlsrv.appveyor.xml +++ b/ci/appveyor/mssql.sql2017.pdo_sqlsrv.appveyor.xml @@ -5,7 +5,9 @@ beStrictAboutOutputDuringTests="true" failOnRisky="true" failOnWarning="true" + failOnPhpunitDeprecation="true" displayDetailsOnTestsThatTriggerWarnings="true" + displayDetailsOnPhpunitDeprecations="true" > diff --git a/ci/appveyor/mssql.sql2017.sqlsrv.appveyor.xml b/ci/appveyor/mssql.sql2017.sqlsrv.appveyor.xml index ee1e3f3c07..9a9d29d5f1 100644 --- a/ci/appveyor/mssql.sql2017.sqlsrv.appveyor.xml +++ b/ci/appveyor/mssql.sql2017.sqlsrv.appveyor.xml @@ -5,7 +5,9 @@ beStrictAboutOutputDuringTests="true" failOnRisky="true" failOnWarning="true" + failOnPhpunitDeprecation="true" displayDetailsOnTestsThatTriggerWarnings="true" + displayDetailsOnPhpunitDeprecations="true" > diff --git a/ci/github/phpunit/ibm_db2.xml b/ci/github/phpunit/ibm_db2.xml index d212824e3f..f75605b8dd 100644 --- a/ci/github/phpunit/ibm_db2.xml +++ b/ci/github/phpunit/ibm_db2.xml @@ -5,7 +5,9 @@ beStrictAboutOutputDuringTests="true" failOnRisky="true" failOnWarning="true" + failOnPhpunitDeprecation="true" displayDetailsOnTestsThatTriggerWarnings="true" + displayDetailsOnPhpunitDeprecations="true" > diff --git a/ci/github/phpunit/mysqli-tls.xml b/ci/github/phpunit/mysqli-tls.xml index 0c104c7a03..0b6ab0c392 100644 --- a/ci/github/phpunit/mysqli-tls.xml +++ b/ci/github/phpunit/mysqli-tls.xml @@ -5,7 +5,9 @@ beStrictAboutOutputDuringTests="true" failOnRisky="true" failOnWarning="true" + failOnPhpunitDeprecation="true" displayDetailsOnTestsThatTriggerWarnings="true" + displayDetailsOnPhpunitDeprecations="true" > diff --git a/ci/github/phpunit/mysqli.xml b/ci/github/phpunit/mysqli.xml index 07ba7cb695..a988660701 100644 --- a/ci/github/phpunit/mysqli.xml +++ b/ci/github/phpunit/mysqli.xml @@ -5,7 +5,9 @@ beStrictAboutOutputDuringTests="true" failOnRisky="true" failOnWarning="true" + failOnPhpunitDeprecation="true" displayDetailsOnTestsThatTriggerWarnings="true" + displayDetailsOnPhpunitDeprecations="true" > diff --git a/ci/github/phpunit/oci8-21.xml b/ci/github/phpunit/oci8-21.xml index 1058a97d3a..5a81a166f8 100644 --- a/ci/github/phpunit/oci8-21.xml +++ b/ci/github/phpunit/oci8-21.xml @@ -5,7 +5,9 @@ beStrictAboutOutputDuringTests="true" failOnRisky="true" failOnWarning="true" + failOnPhpunitDeprecation="true" displayDetailsOnTestsThatTriggerWarnings="true" + displayDetailsOnPhpunitDeprecations="true" > diff --git a/ci/github/phpunit/oci8.xml b/ci/github/phpunit/oci8.xml index 8282e2d439..e576998d66 100644 --- a/ci/github/phpunit/oci8.xml +++ b/ci/github/phpunit/oci8.xml @@ -5,7 +5,9 @@ beStrictAboutOutputDuringTests="true" failOnRisky="true" failOnWarning="true" + failOnPhpunitDeprecation="true" displayDetailsOnTestsThatTriggerWarnings="true" + displayDetailsOnPhpunitDeprecations="true" > diff --git a/ci/github/phpunit/pdo_mysql.xml b/ci/github/phpunit/pdo_mysql.xml index ce9b5b82c9..dfc4b5a728 100644 --- a/ci/github/phpunit/pdo_mysql.xml +++ b/ci/github/phpunit/pdo_mysql.xml @@ -5,7 +5,9 @@ beStrictAboutOutputDuringTests="true" failOnRisky="true" failOnWarning="true" + failOnPhpunitDeprecation="true" displayDetailsOnTestsThatTriggerWarnings="true" + displayDetailsOnPhpunitDeprecations="true" > diff --git a/ci/github/phpunit/pdo_oci-21.xml b/ci/github/phpunit/pdo_oci-21.xml index e2ed303558..22f972b672 100644 --- a/ci/github/phpunit/pdo_oci-21.xml +++ b/ci/github/phpunit/pdo_oci-21.xml @@ -5,7 +5,9 @@ beStrictAboutOutputDuringTests="true" failOnRisky="true" failOnWarning="true" + failOnPhpunitDeprecation="true" displayDetailsOnTestsThatTriggerWarnings="true" + displayDetailsOnPhpunitDeprecations="true" > diff --git a/ci/github/phpunit/pdo_oci.xml b/ci/github/phpunit/pdo_oci.xml index 587e209926..4a11c90287 100644 --- a/ci/github/phpunit/pdo_oci.xml +++ b/ci/github/phpunit/pdo_oci.xml @@ -5,7 +5,9 @@ beStrictAboutOutputDuringTests="true" failOnRisky="true" failOnWarning="true" + failOnPhpunitDeprecation="true" displayDetailsOnTestsThatTriggerWarnings="true" + displayDetailsOnPhpunitDeprecations="true" > diff --git a/ci/github/phpunit/pdo_pgsql.xml b/ci/github/phpunit/pdo_pgsql.xml index 0950c0aaab..c7584b7eb9 100644 --- a/ci/github/phpunit/pdo_pgsql.xml +++ b/ci/github/phpunit/pdo_pgsql.xml @@ -5,7 +5,9 @@ beStrictAboutOutputDuringTests="true" failOnRisky="true" failOnWarning="true" + failOnPhpunitDeprecation="true" displayDetailsOnTestsThatTriggerWarnings="true" + displayDetailsOnPhpunitDeprecations="true" > diff --git a/ci/github/phpunit/pdo_sqlite.xml b/ci/github/phpunit/pdo_sqlite.xml index 0ea97c66ba..4fadcfe472 100644 --- a/ci/github/phpunit/pdo_sqlite.xml +++ b/ci/github/phpunit/pdo_sqlite.xml @@ -5,7 +5,9 @@ beStrictAboutOutputDuringTests="true" failOnRisky="true" failOnWarning="true" + failOnPhpunitDeprecation="true" displayDetailsOnTestsThatTriggerWarnings="true" + displayDetailsOnPhpunitDeprecations="true" > diff --git a/ci/github/phpunit/pdo_sqlsrv.xml b/ci/github/phpunit/pdo_sqlsrv.xml index 5535d82148..45b510604c 100644 --- a/ci/github/phpunit/pdo_sqlsrv.xml +++ b/ci/github/phpunit/pdo_sqlsrv.xml @@ -5,7 +5,9 @@ beStrictAboutOutputDuringTests="true" failOnRisky="true" failOnWarning="true" + failOnPhpunitDeprecation="true" displayDetailsOnTestsThatTriggerWarnings="true" + displayDetailsOnPhpunitDeprecations="true" > diff --git a/ci/github/phpunit/pgsql.xml b/ci/github/phpunit/pgsql.xml index 3168e16992..a1764f34b4 100644 --- a/ci/github/phpunit/pgsql.xml +++ b/ci/github/phpunit/pgsql.xml @@ -5,7 +5,9 @@ beStrictAboutOutputDuringTests="true" failOnRisky="true" failOnWarning="true" + failOnPhpunitDeprecation="true" displayDetailsOnTestsThatTriggerWarnings="true" + displayDetailsOnPhpunitDeprecations="true" > diff --git a/ci/github/phpunit/sqlite3.xml b/ci/github/phpunit/sqlite3.xml index 315e39b896..56e5af7457 100644 --- a/ci/github/phpunit/sqlite3.xml +++ b/ci/github/phpunit/sqlite3.xml @@ -5,7 +5,9 @@ beStrictAboutOutputDuringTests="true" failOnRisky="true" failOnWarning="true" + failOnPhpunitDeprecation="true" displayDetailsOnTestsThatTriggerWarnings="true" + displayDetailsOnPhpunitDeprecations="true" > diff --git a/ci/github/phpunit/sqlsrv.xml b/ci/github/phpunit/sqlsrv.xml index aa27ac47d5..41d87002b0 100644 --- a/ci/github/phpunit/sqlsrv.xml +++ b/ci/github/phpunit/sqlsrv.xml @@ -5,7 +5,9 @@ beStrictAboutOutputDuringTests="true" failOnRisky="true" failOnWarning="true" + failOnPhpunitDeprecation="true" displayDetailsOnTestsThatTriggerWarnings="true" + displayDetailsOnPhpunitDeprecations="true" > diff --git a/phpunit.xml.dist b/phpunit.xml.dist index 51f3c396ea..974a65c503 100644 --- a/phpunit.xml.dist +++ b/phpunit.xml.dist @@ -17,7 +17,9 @@ beStrictAboutOutputDuringTests="true" failOnRisky="true" failOnWarning="true" + failOnPhpunitDeprecation="true" displayDetailsOnTestsThatTriggerWarnings="true" + displayDetailsOnPhpunitDeprecations="true" >