From 0042ffb4bc011e23a5aecb7cd1facee178ea28ee Mon Sep 17 00:00:00 2001 From: Sergei Morozov Date: Mon, 12 May 2025 15:06:56 -0700 Subject: [PATCH 1/2] Use fail-fast with shivammathur/setup-php@v2 --- .github/workflows/continuous-integration.yml | 2 ++ .github/workflows/nightly.yml | 2 ++ .github/workflows/phpunit-db2.yml | 1 + .github/workflows/phpunit-mariadb.yml | 2 ++ .github/workflows/phpunit-mysql.yml | 2 ++ .github/workflows/phpunit-oracle.yml | 2 ++ .github/workflows/phpunit-postgres.yml | 2 ++ .github/workflows/phpunit-sqlite.yml | 2 ++ .github/workflows/phpunit-sqlserver.yml | 2 ++ 9 files changed, 17 insertions(+) diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index a24743eee5..a01a73ab08 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -235,6 +235,8 @@ jobs: uses: "shivammathur/setup-php@v2" with: php-version: "${{ matrix.php-version }}" + env: + fail-fast: true - name: "Lower minimum stability" run: "composer config minimum-stability dev" diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index d4c900bb84..ea99e4f5aa 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -50,6 +50,8 @@ jobs: coverage: "pcov" ini-values: "zend.assertions=1" extensions: "${{ matrix.extension }}" + env: + fail-fast: true - name: "Install dependencies with Composer" uses: "ramsey/composer-install@v3" diff --git a/.github/workflows/phpunit-db2.yml b/.github/workflows/phpunit-db2.yml index 836ea254f5..649333c750 100644 --- a/.github/workflows/phpunit-db2.yml +++ b/.github/workflows/phpunit-db2.yml @@ -47,6 +47,7 @@ jobs: coverage: pcov ini-values: zend.assertions=1 env: + fail-fast: true IBM_DB2_CONFIGURE_OPTS: '--with-IBM_DB2=/tmp/clidriver' - name: Install dependencies with Composer diff --git a/.github/workflows/phpunit-mariadb.yml b/.github/workflows/phpunit-mariadb.yml index 2aab0602a6..0955390f2a 100644 --- a/.github/workflows/phpunit-mariadb.yml +++ b/.github/workflows/phpunit-mariadb.yml @@ -39,6 +39,8 @@ jobs: extensions: ${{ inputs.extension }} coverage: pcov ini-values: zend.assertions=1 + env: + fail-fast: true - name: Install dependencies with Composer uses: ramsey/composer-install@v3 diff --git a/.github/workflows/phpunit-mysql.yml b/.github/workflows/phpunit-mysql.yml index 11f7123a05..8e9b65784a 100644 --- a/.github/workflows/phpunit-mysql.yml +++ b/.github/workflows/phpunit-mysql.yml @@ -43,6 +43,8 @@ jobs: extensions: ${{ inputs.extension }} coverage: pcov ini-values: zend.assertions=1 + env: + fail-fast: true - name: Install dependencies with Composer uses: ramsey/composer-install@v3 diff --git a/.github/workflows/phpunit-oracle.yml b/.github/workflows/phpunit-oracle.yml index 3827bb22df..d3c0b1459e 100644 --- a/.github/workflows/phpunit-oracle.yml +++ b/.github/workflows/phpunit-oracle.yml @@ -41,6 +41,8 @@ jobs: extensions: ${{ inputs.extension }} coverage: pcov ini-values: zend.assertions=1 + env: + fail-fast: true - name: Install dependencies with Composer uses: ramsey/composer-install@v3 diff --git a/.github/workflows/phpunit-postgres.yml b/.github/workflows/phpunit-postgres.yml index 4173eb7483..53e74f37db 100644 --- a/.github/workflows/phpunit-postgres.yml +++ b/.github/workflows/phpunit-postgres.yml @@ -38,6 +38,8 @@ jobs: extensions: ${{ inputs.extension }} coverage: pcov ini-values: zend.assertions=1 + env: + fail-fast: true - name: Install dependencies with Composer uses: ramsey/composer-install@v3 diff --git a/.github/workflows/phpunit-sqlite.yml b/.github/workflows/phpunit-sqlite.yml index 543105d719..8e369145c3 100644 --- a/.github/workflows/phpunit-sqlite.yml +++ b/.github/workflows/phpunit-sqlite.yml @@ -30,6 +30,8 @@ jobs: php-version: ${{ inputs.php-version }} coverage: pcov ini-values: zend.assertions=1 + env: + fail-fast: true - name: Install dependencies with Composer uses: ramsey/composer-install@v3 diff --git a/.github/workflows/phpunit-sqlserver.yml b/.github/workflows/phpunit-sqlserver.yml index cb6f0b3104..f73d346989 100644 --- a/.github/workflows/phpunit-sqlserver.yml +++ b/.github/workflows/phpunit-sqlserver.yml @@ -41,6 +41,8 @@ jobs: coverage: pcov ini-values: zend.assertions=1 tools: pecl + env: + fail-fast: true - name: Install dependencies with Composer uses: ramsey/composer-install@v3 From 55f6edd640c747bd662256c4952e9b37fc14eba7 Mon Sep 17 00:00:00 2001 From: Sergei Morozov Date: Mon, 12 May 2025 15:07:29 -0700 Subject: [PATCH 2/2] Do not use fail-fast in nightly builds --- .github/workflows/nightly.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index ea99e4f5aa..aeae23ac68 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -4,9 +4,6 @@ on: schedule: - cron: "12 3 * * *" -env: - fail-fast: true - jobs: phpunit-mariadb-devel: name: "PHPUnit with MariaDB"