8000 Fixing image manifest schema2 medaitype typo in docs. by ipanova · Pull Request #2315 · distribution/distribution · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixing image manifest schema2 medaitype typo in docs. #2315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2017
Merged

Fixing image manifest schema2 medaitype typo in docs. #2315

merged 1 commit into from
Jun 27, 2017

Conversation

ipanova
Copy link
Contributor
@ipanova ipanova commented Jun 23, 2017

Docs need to correspond to what is actually in the code.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "mediatype-typo" git@github.com:ipanova/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@ipanova
Fixing image manifest schema2 medaitype typo in docs.
5ccd03d 
Signed-off-by: Ina Panova <ipanova@redhat.com>
@codecov
Copy link
codecov bot commented Jun 23, 2017 •
edited
Loading

Codecov Report

Merging #2315 into master will decrease coverage by 10.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #2315       +/-   ##
==========================================
- Coverage   61.57%   51.5%   -10.08%     
==========================================
  Files         125     125               
  Lines       11397   11397               
==========================================
- Hits         7018    5870     -1148     
- Misses       3493    4781     +1288     
+ Partials      886     746      -140
Impacted Files Coverage Δ
registry/storage/driver/gcs/gcs.go 0.4% <0%> (-68.94%) ⬇️
registry/storage/driver/oss/oss.go 0.56% <0%> (-57.23%) ⬇️
registry/storage/driver/s3-aws/s3.go 4.57% <0%> (-56.23%) ⬇️
registry/storage/driver/s3-goamz/s3.go 0.5% <0%> (-51.4%) ⬇️
registry/client/transport/transport.go 69.69% <0%> (-9.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e2f10e...5ccd03d. Read the comment docs.

@dmage
Copy link
Contributor
dmage commented Jun 26, 2017

@aaronlehmann you are the author of these lines, could you take a look?

@aaronlehmann
Copy link
Contributor

LGTM

ping @dmcgowan @stevvooe

@aaronlehmann aaronlehmann merged commit f86db6b into distribution:master Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ipanova @GordonTheTurtle @dmage @aaronlehmann
0