8000 Remove expires tag from s3 upload by nivlaaa · Pull Request #2215 · distribution/distribution · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Dismiss alert

Remove expires tag from s3 upload #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2017
Merged

Remove expires tag from s3 upload #2215

merged 1 commit into from
Apr 7, 2017

Conversation

nivlaaa
Copy link
Contributor
@nivlaaa nivlaaa commented Mar 17, 2017

As discussed in #2194, when uploading to S3, the Expires tag should not be set as it causes caches to not cache layers after 30 minutes. See documentation https://docs.aws.amazon.com/sdk-for-go/api/service/s3/ and search for Expires.

Signed-off-by: Alvin Feng alvin4feng@yahoo.com

@nivlaaa
Remove expires tag from s3 upload
45bb7c9 
Signed-off-by: Alvin Feng <alvin4feng@yahoo.com>
@codecov
Copy link
codecov bot commented Mar 17, 2017 •
edited
Loading

Codecov Report

Merging #2215 into master will decrease coverage by 10.62%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2215       +/-   ##
===========================================
- Coverage   62.35%   51.73%   -10.63%     
===========================================
  Files         120      125        +5     
  Lines       11323    11450      +127     
===========================================
- Hits         7061     5924     -1137     
- Misses       3385     4780     +1395     
+ Partials      877      746      -131
Impacted Files Coverage Δ
registry/storage/driver/s3-aws/s3.go 4.59% <ø> (-56.3%) ❌
registry/storage/driver/gcs/gcs.go 0.4% <0%> (-68.94%) ❌
registry/storage/driver/oss/oss.go 0.56% <0%> (-57.23%) ❌
errors.go 19.04% <0%> (-51.73%) ❌
registry/storage/driver/s3-goamz/s3.go 0.5% <0%> (-50.76%) ❌
registry.go 33.33% <0%> (-28.82%) ❌
registry/client/transport/transport.go 69.69% <0%> (-9.1%) ❌
registry/handlers/manifests.go 55.88% <0%> (ø)
registry/storage/registry.go 90.14% <0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08b06dc...45bb7c9. Read the comment docs.

@nivlaaa nivlaaa mentioned this pull request Mar 18, 2017
Closed
nwt
nwt approved these changes Mar 18, 2017
View reviewed changes
Copy link
Contributor
@nwt nwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @alvinfeng.

@dmcgowan
Copy link
Collaborator

LGTM

@dmcgowan dmcgowan added this to the Registry/2.7 milestone Mar 21, 2017
@stevvooe
Copy link
Collaborator
stevvooe commented Apr 7, 2017

LGTM

@stevvooe stevvooe merged commit 7b9ebdc into distribution:master Apr 7, 2017
@nivlaaa nivlaaa deleted the expires branch June 29, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwt nwt nwt approved these changes

Assignees
No one assigned
Labels
impact/changelog regression
Projects
None yet
Milestone
Registry/2.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nivlaaa @dmcgowan @stevvooe @nwt
0