Plugin integration test #2085
Merged
Plugin integration test #2085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
- Add plugin push and pull tests. Tests that images pushed as plugins cannot be pulled as images and vice versa.
- Additional base image used for creating plugin rootfs
- Updates login to allow supply the email flag in less than docker 1.11. Needed to support 1.13 which removes the email flag.
Current coverage is 51.20% (diff: 100%)@@ master #2085 diff @@
==========================================
Files 129 129
Lines 11416 11416
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6990 5846 -1144
- Misses 3535 4821 +1286
+ Partials 891 749 -142
|
|
LGTM |
|
Going to wait until docker rc4 to merge this so I can update the test to run against 1.13 before merging. |
340a74f to
62ec73c
Compare
|
ping @dmcgowan what's the status on this one? |
|
Still one failure and waiting for the rc5 docker image to come out. Once that is updated and janky passes will merge. |
e0be2bd to
7f4ccf0
Compare
Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
Use rc4 for support with plugins change Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
7f4ccf0 to
fd13a2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.